Merge tests

Author: VincentLanglet

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2753,27 +2753,6 @@ public function testBug11619Strict(): void
 		$this->analyse([__DIR__ . '/data/bug-11619-strict.php'], []);
 	}
 
-	#[RequiresPhp('>= 8.1')]
-	public function testBug11619Error(): void
-	{
-		$this->analyse([__DIR__ . '/data/bug-11619-error.php'], [
-			[
-				'Parameter #1 $string1 of function strnatcasecmp expects string, Bug11619Error\Foo given.',
-				32,
-			],
-			[
-				'Parameter #2 $string2 of function strnatcasecmp expects string, Bug11619Error\Foo given.',
-				32,
-			],
-		]);
-	}
-
-	#[RequiresPhp('>= 8.1')]
-	public function testBug11619Typed(): void
-	{
-		$this->analyse([__DIR__ . '/data/bug-11619-typed.php'], []);
-	}
-
 	public function testBug13247(): void
 	{
 		$this->analyse([__DIR__ . '/data/bug-13247.php'], []);

tests/PHPStan/Rules/Functions/data/bug-11619-error.php

@@ -27,4 +27,29 @@ function test(): void
 
 	uasort($options, 'strnatcasecmp');
 	usort($options, 'strnatcasecmp');
+
+	uasort($options, fn($a, $b) => strnatcasecmp($a, $b));
+	uasort($options, fn(string $a, string $b) => strnatcasecmp($a, $b));
+}
+
+/**
+ * @param array<\Stringable> $a
+ * @param callable(\Stringable, \Stringable): int $f
+ */
+function customUsort(array &$a, callable $f): void
+{
+	for ($i = 1; $i < count($a); $i++)
+		for ($j = $i; $j > 0 && $f($a[$j-1], $a[$j]) > 0; $j--)
+			[$a[$j-1], $a[$j]] = [$a[$j], $a[$j-1]];
+}
+
+function test2(): void
+{
+	$options = [
+		Foo::fromString('c'),
+		Foo::fromString('b'),
+		Foo::fromString('a'),
+	];
+
+	customUsort($options, 'strnatcasecmp');
 }

tests/PHPStan/Rules/Functions/data/bug-11619-strict.php

@@ -27,4 +27,29 @@ function test(): void
 
 	uasort($options, 'strnatcasecmp');
 	usort($options, 'strnatcasecmp');
+
+	uasort($options, fn($a, $b) => strnatcasecmp($a, $b));
+	uasort($options, fn(string $a, string $b) => strnatcasecmp($a, $b));
+}
+
+/**
+ * @param array<\Stringable> $a
+ * @param callable(\Stringable, \Stringable): int $f
+ */
+function customUsort(array &$a, callable $f): void
+{
+	for ($i = 1; $i < count($a); $i++)
+		for ($j = $i; $j > 0 && $f($a[$j-1], $a[$j]) > 0; $j--)
+			[$a[$j-1], $a[$j]] = [$a[$j], $a[$j-1]];
+}
+
+function test2(): void
+{
+	$options = [
+		Foo::fromString('c'),
+		Foo::fromString('b'),
+		Foo::fromString('a'),
+	];
+
+	customUsort($options, 'strnatcasecmp');
 }