Check types when argument is passed by reference for userland functions

Author: ljmaskey

src/Rules/FunctionCallParametersCheck.php

@@ -252,7 +252,7 @@ public function check(
 			if ($this->checkArgumentTypes) {
 				$parameterType = TypeUtils::resolveLateResolvableTypes($parameter->getType());
 
-				if (!$parameter->passedByReference()->createsNewVariable()) {
+				if (!$parameter->passedByReference()->createsNewVariable() || !$isBuiltin) {
 					$accepts = $this->ruleLevelHelper->acceptsWithReason($parameterType, $argumentValueType, $scope->isDeclareStrictTypes());
 
 					if (!$accepts->result) {

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -297,6 +297,10 @@ public function testPassingNonVariableToParameterPassedByReference(): void
 				'Parameter #1 $array of function reset expects array|object, null given.',
 				39,
 			],
+			[
+				'Parameter #1 $s of function PassedByReference\bar expects string, int given.',
+				48,
+			],
 		]);
 	}
 
@@ -1623,4 +1627,18 @@ public function testDiscussion10454(): void
 		]);
 	}
 
+	public function testBug10626(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-10626.php'], [
+			[
+				'Parameter #1 $value of function Bug10626\intByValue expects int, string given.',
+				16,
+			],
+			[
+				'Parameter #1 $value of function Bug10626\intByReference expects int, string given.',
+				17,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/bug-10626.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace Bug10626;
+
+function intByValue(int $value): void
+{
+
+}
+
+function intByReference(int &$value): void
+{
+
+}
+
+$notAnInt = 'not-an-int';
+intByValue($notAnInt);
+intByReference($notAnInt);

tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php

@@ -629,6 +629,21 @@ public function testBug5781(): void
 		]);
 	}
 
+	public function testBug8296(): void
+	{
+		$this->checkThisOnly = false;
+		$this->analyse([__DIR__ . '/data/bug-8296.php'], [
+			[
+				'Parameter #1 $objects of static method Bug8296\VerifyLoginTask::continueDump() expects array<string, object>, array<string, Bug8296\stdClass|true> given.',
+				12,
+			],
+			[
+				'Parameter #1 $string of static method Bug8296\VerifyLoginTask::stringByRef() expects string, int given.',
+				15,
+			],
+		]);
+	}
+
 	public function testRequireExtends(): void
 	{
 		$this->checkThisOnly = false;

tests/PHPStan/Rules/Methods/data/bug-8296.php

@@ -0,0 +1,29 @@
+<?php
+
+namespace Bug8296;
+
+class VerifyLoginTask{
+
+	public static function dumpMemory() : void{
+		$dummy = [
+			"a" => new stdClass(),
+			"b" => true
+		];
+		self::continueDump($dummy);
+
+		$string = 12345;
+		self::stringByRef($string);
+	}
+
+	/**
+	 * @phpstan-param array<string, object> $objects
+	 * @phpstan-param-out array<string, object> $objects
+	 */
+	private static function continueDump(array &$objects) : void{
+
+	}
+
+	private static function stringByRef(string &$string) : void{
+
+	}
+}