Fix

Author: VincentLanglet

tests/PHPStan/Rules/Classes/data/bug-11006.php

@@ -1,19 +1,14 @@
-<?php declare(strict_types = 1);
+<?php // lint >= 8.0
 
-namespace Bug11006;
+declare(strict_types = 1);
 
-class StringOrNullAttributeDto
-{
-	public function __construct(
-		public ?string $data,
-	) {
-	}
-}
+namespace Bug11006;
 
-class StringAttributeDto
+class ProductParentPayloadDto
 {
+	/** @param null|'size_uk'|'size_us' $SizeAttributeCode */
 	public function __construct(
-		public string $data,
+		public ?string $SizeAttributeCode,
 	) {
 	}
 }
@@ -34,33 +29,46 @@ public function __construct(
 	}
 }
 
-class ProductParentPayloadDto
+class StringOrNullAttributeDto
 {
-	/**
-	 * @param 'size_uk'|'size_us' $SizeAttributeCode
-	 */
 	public function __construct(
-		public string $SizeAttributeCode,
+		public ?string $data,
 	) {
 	}
 }
 
+class StringAttributeDto
+{
+	public function __construct(
+		public string $data,
+	) {
+	}
+}
+
+
 class PhpStanProblem
 {
-	public function example(ProductParentPayloadDto $parentPayload): void
+	public function example(ProductParentPayloadDto $productParentPayloadDto): void
 	{
+		if (null === $productParentPayloadDto->SizeAttributeCode) {
+			return;
+		}
+
 		$values = [
 			'ean' => [
 				new StringOrNullAttributeDto(''),
 			],
-			$parentPayload->SizeAttributeCode => [
+			$productParentPayloadDto->SizeAttributeCode => [
 				new StringOrNullAttributeDto(''),
 			],
+			// This part goes wrong
 			'osa_sizes' => [
 				new StringAttributeDto(''),
 			],
 		];
 
-		new AkeneoUpdateProductDto($values);
+		$productData = new AkeneoUpdateProductDto(
+			values: $values,
+		);
 	}
 }

tests/PHPStan/Rules/Operators/data/bug-14080.php

@@ -2,24 +2,18 @@
 
 namespace Bug14080;
 
-class Foo
-{
-	/**
-	 * @param list<array{sql: string, time: int}> $queries
-	 */
-	public function doFoo(array $queries): void
-	{
-		$queryTotals = ['all' => 0, 'duplicates' => 0];
-		$queryTypes = ['select', 'update', 'delete', 'insert'];
+$queryTotals = ['all' => 0, 'duplicates' => 0];
+$queryTypes = ['select', 'update', 'delete', 'insert'];
+$queries = [['sql' => 'select', 'time' => 8234], ['sql' => 'select', 'time' => 4558], ['sql' => 'insert', 'time' => 9928]];
 
-		$queryTotals['time'] = array_sum(array_column($queries, 'time'));
+$queryTotals['time'] = array_sum(array_column($queries, 'time'));
 
-		foreach ($queryTypes as $type) {
-			$tq = array_filter($queries, fn ($v) => str_starts_with(strtolower($v['sql']), $type));
-			$queryTotals['all'] += count($tq);
-			$queryTotals[$type] = [
-				'count' => count($tq),
-			];
-		}
-	}
+foreach ($queryTypes as $type) {
+	$tq = array_filter($queries, fn ($v) => str_starts_with(strtolower($v['sql']), $type));
+	$tq_time = array_sum(array_column($tq, 'time'));
+	$queryTotals['all'] += count($tq);
+	$queryTotals[$type] = [
+		'count' => count($tq),
+		'time' => $tq_time / $queryTotals['time'] * 100,
+	];
 }

tests/PHPStan/Rules/Variables/NullCoalesceRuleTest.php

@@ -372,22 +372,4 @@ public function testBug13921(): void
 		]);
 	}
 
-	public function testBug13623(): void
-	{
-		$this->analyse([__DIR__ . '/data/bug-13623.php'], [
-			[
-				'Offset \'new_invoice\' on array{balance_forward: 0, new_invoice: 0, payments: 0, balance: float} on left side of ??= always exists and is not nullable.',
-				18,
-			],
-			[
-				'Offset \'payments\' on array{balance_forward: 0, new_invoice: 0, payments: 0, balance: float} on left side of ??= always exists and is not nullable.',
-				19,
-			],
-			[
-				'Offset \'balance\' on array{balance_forward: 0, new_invoice: 0, payments: 0, balance: float} on left side of ??= always exists and is not nullable.',
-				20,
-			],
-		]);
-	}
-
 }