Commit f99c6ec
Fix phpstan/phpstan#14314: Incorrect count narrowing removes unrelated constant arrays from union
- Added fallback in TypeSpecifier::specifyTypesForCountFuncCall for falsey context
- When recursive truthy call fails (remaining size includes 0), directly filter
constant arrays by their exact sizes instead of using TypeCombinator::remove
- This avoids the issue where remove() considers a shorter constant array as a
supertype of a longer one, incorrectly eliminating both from the union
- New regression test in tests/PHPStan/Analyser/nsrt/bug-14314.php1 parent 79e39da commit f99c6ec
2 files changed
Lines changed: 41 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1294 | 1294 | | |
1295 | 1295 | | |
1296 | 1296 | | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
| 1302 | + | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
| 1313 | + | |
| 1314 | + | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
1297 | 1318 | | |
1298 | 1319 | | |
1299 | 1320 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
0 commit comments