Fix phpstan/phpstan#14397: FILTER_FLAG_GLOBAL_RANGE false positive on PHP 8.3/8.4

- FILTER_FLAG_GLOBAL_RANGE (268435456) has the same numeric value as FILTER_THROW_ON_FAILURE on PHP 8.3/8.4
- This caused PHPStan to incorrectly think filter_var would throw, removing false from the return type
- Gate all FILTER_THROW_ON_FAILURE checks behind PHP >= 8.5 (where the constant was introduced)
- Applied fix to FilterFunctionReturnTypeHelper, FilterVarThrowTypeExtension, and FilterVarRule
- Updated FilterVarRuleTest to pass new PhpVersion constructor parameter
- New regression test in tests/PHPStan/Analyser/nsrt/bug-14397.php

Author: VincentLanglet

src/Rules/Functions/FilterVarRule.php

@@ -7,6 +7,7 @@
 use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
 use PHPStan\DependencyInjection\RegisteredRule;
+use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -23,6 +24,7 @@ final class FilterVarRule implements Rule
 	public function __construct(
 		private ReflectionProvider $reflectionProvider,
 		private FilterFunctionReturnTypeHelper $filterFunctionReturnTypeHelper,
+		private PhpVersion $phpVersion,
 	)
 	{
 	}
@@ -44,7 +46,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$args = $node->getArgs();
 
-		if ($this->reflectionProvider->hasConstant(new Name\FullyQualified('FILTER_THROW_ON_FAILURE'), null)) {
+		if ($this->phpVersion->getVersionId() >= 80500 && $this->reflectionProvider->hasConstant(new Name\FullyQualified('FILTER_THROW_ON_FAILURE'), null)) {
 			if (count($args) < 3) {
 				return [];
 			}

src/Type/Php/FilterFunctionReturnTypeHelper.php

@@ -151,7 +151,9 @@ public function getType(Type $inputType, ?Type $filterType, ?Type $flagsType): T
 
 		$inputIsArray = $inputType->isArray();
 		$hasRequireArrayFlag = $this->hasFlag('FILTER_REQUIRE_ARRAY', $flagsType);
-		$hasThrowOnFailureFlag = $this->hasFlag('FILTER_THROW_ON_FAILURE', $flagsType);
+		$hasThrowOnFailureFlag = $this->phpVersion->getVersionId() >= 80500
+			? $this->hasFlag('FILTER_THROW_ON_FAILURE', $flagsType)
+			: TrinaryLogic::createNo();
 		if ($inputIsArray->no() && $hasRequireArrayFlag->yes()) {
 			if ($hasThrowOnFailureFlag->yes()) {
 				return new ErrorType();

src/Type/Php/FilterVarThrowTypeExtension.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
 use PHPStan\DependencyInjection\AutowiredService;
+use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\Constant\ConstantIntegerType;
@@ -20,6 +21,7 @@ final class FilterVarThrowTypeExtension implements DynamicFunctionThrowTypeExten
 
 	public function __construct(
 		private ReflectionProvider $reflectionProvider,
+		private PhpVersion $phpVersion,
 	)
 	{
 	}
@@ -29,6 +31,7 @@ public function isFunctionSupported(
 	): bool
 	{
 		return $functionReflection->getName() === 'filter_var'
+			&& $this->phpVersion->getVersionId() >= 80500
 			&& $this->reflectionProvider->hasConstant(new Name\FullyQualified('FILTER_THROW_ON_FAILURE'), null);
 	}
 

tests/PHPStan/Analyser/nsrt/bug-14397.php

@@ -0,0 +1,13 @@
+<?php // lint >= 8.2
+
+declare(strict_types = 1);
+
+namespace Bug14397;
+
+use function filter_var;
+use function PHPStan\Testing\assertType;
+
+function test(string $ipAddress): void
+{
+	assertType('non-falsy-string|false', filter_var($ipAddress, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4 | FILTER_FLAG_GLOBAL_RANGE));
+}

tests/PHPStan/Rules/Functions/FilterVarRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Functions;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 use PHPStan\Type\Php\FilterFunctionReturnTypeHelper;
@@ -16,6 +17,7 @@ protected function getRule(): Rule
 		return new FilterVarRule(
 			self::createReflectionProvider(),
 			self::getContainer()->getByType(FilterFunctionReturnTypeHelper::class),
+			self::getContainer()->getByType(PhpVersion::class),
 		);
 	}