Introduce isDummy

staabm · VincentLanglet · commit fcf056104e8b · 2026-02-19T19:47:23.000+01:00
diff --git a/src/Reflection/Annotations/AnnotationMethodReflection.php b/src/Reflection/Annotations/AnnotationMethodReflection.php
@@ -194,4 +194,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return null;
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Dummy/ChangedTypeMethodReflection.php b/src/Reflection/Dummy/ChangedTypeMethodReflection.php
@@ -183,4 +183,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return $this->reflection->getResolvedPhpDoc();
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return $this->reflection->isDummy();
+	}
+
 }
diff --git a/src/Reflection/Dummy/DummyConstructorReflection.php b/src/Reflection/Dummy/DummyConstructorReflection.php
@@ -169,4 +169,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return null;
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::createYes();
+	}
+
 }
diff --git a/src/Reflection/Dummy/DummyMethodReflection.php b/src/Reflection/Dummy/DummyMethodReflection.php
@@ -161,4 +161,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return null;
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::createYes();
+	}
+
 }
diff --git a/src/Reflection/ExtendedMethodReflection.php b/src/Reflection/ExtendedMethodReflection.php
@@ -80,4 +80,11 @@ public function mustUseReturnValue(): TrinaryLogic;
 
 	public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock;
 
+	/**
+	 * Returns yes() for methods that represent possibly-defined method
+	 * on non-final classes, mixed, object, etc. — placeholders PHPStan creates
+	 * when it cannot prove a method doesn't exist.
+	 */
+	public function isDummy(): TrinaryLogic;
+
 }
diff --git a/src/Reflection/Native/NativeMethodReflection.php b/src/Reflection/Native/NativeMethodReflection.php
@@ -243,4 +243,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return $this->resolvedPhpDocBlock;
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Php/ClosureCallMethodReflection.php b/src/Reflection/Php/ClosureCallMethodReflection.php
@@ -213,4 +213,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return $this->nativeMethodReflection->getResolvedPhpDoc();
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Php/EnumCasesMethodReflection.php b/src/Reflection/Php/EnumCasesMethodReflection.php
@@ -172,4 +172,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return null;
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Php/PhpMethodFromParserNodeReflection.php b/src/Reflection/Php/PhpMethodFromParserNodeReflection.php
@@ -303,4 +303,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return $this->resolvedPhpDoc;
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -485,4 +485,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return $this->resolvedPhpDocBlock;
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Reflection/ResolvedMethodReflection.php b/src/Reflection/ResolvedMethodReflection.php
@@ -232,4 +232,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return $this->reflection->getResolvedPhpDoc();
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return $this->reflection->isDummy();
+	}
+
 }
diff --git a/src/Reflection/Type/IntersectionTypeMethodReflection.php b/src/Reflection/Type/IntersectionTypeMethodReflection.php
@@ -239,4 +239,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return $this->methods[0]->getResolvedPhpDoc();
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::lazyMaxMin($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->isDummy());
+	}
+
 }
diff --git a/src/Reflection/Type/UnionTypeMethodReflection.php b/src/Reflection/Type/UnionTypeMethodReflection.php
@@ -222,4 +222,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return $this->methods[0]->getResolvedPhpDoc();
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::lazyExtremeIdentity($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->isDummy());
+	}
+
 }
diff --git a/src/Reflection/WrappedExtendedMethodReflection.php b/src/Reflection/WrappedExtendedMethodReflection.php
@@ -185,4 +185,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return null;
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return TrinaryLogic::createNo();
+	}
+
 }
diff --git a/src/Rules/Methods/MethodCallableRule.php b/src/Rules/Methods/MethodCallableRule.php
@@ -10,6 +10,7 @@
 use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use stdClass;
 use function sprintf;
 
 /**
@@ -47,7 +48,7 @@ public function processNode(Node $node, Scope $scope): array
 		$methodNameName = $methodName->toString();
 
 		[$errors, $methodReflection] = $this->methodCallCheck->check($scope, $methodNameName, $node->getVar(), $node->getName());
-		if ($methodReflection === null) {
+		if ($methodReflection === null || $methodReflection->isDummy()->yes()) {
 			return $errors;
 		}
 
diff --git a/src/Rules/Methods/StaticMethodCallableRule.php b/src/Rules/Methods/StaticMethodCallableRule.php
@@ -10,6 +10,7 @@
 use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use stdClass;
 use function sprintf;
 
 /**
@@ -47,7 +48,7 @@ public function processNode(Node $node, Scope $scope): array
 		$methodNameName = $methodName->toString();
 
 		[$errors, $methodReflection] = $this->methodCallCheck->check($scope, $methodNameName, $node->getClass(), $node->getName());
-		if ($methodReflection === null) {
+		if ($methodReflection === null || $methodReflection->isDummy()->yes()) {
 			return $errors;
 		}
 
diff --git a/src/Rules/RestrictedUsage/RewrittenDeclaringClassMethodReflection.php b/src/Rules/RestrictedUsage/RewrittenDeclaringClassMethodReflection.php
@@ -156,4 +156,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock
 		return $this->methodReflection->getResolvedPhpDoc();
 	}
 
+	public function isDummy(): TrinaryLogic
+	{
+		return $this->methodReflection->isDummy();
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Methods/MethodCallableRuleTest.php b/tests/PHPStan/Rules/Methods/MethodCallableRuleTest.php
@@ -39,6 +39,12 @@ public function testNotSupportedOnOlderVersions(): void
 		]);
 	}
 
+	#[RequiresPhp('>= 8.1')]
+	public function testBug13596(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13596.php'], []);
+	}
+
 	#[RequiresPhp('>= 8.1')]
 	public function testRule(): void
 	{
diff --git a/tests/PHPStan/Rules/Methods/data/bug-13596.php b/tests/PHPStan/Rules/Methods/data/bug-13596.php
@@ -0,0 +1,31 @@
+<?php // lint >= 8.1
+
+namespace Bug13596;
+
+use Closure;
+
+class BaseClass
+{
+	public function getCallable(): ?Closure
+	{
+		return method_exists($this, 'myCallable') ? $this->myCallable(...) : null;
+	}
+
+	public function getCallableWithIsCallable(): ?Closure
+	{
+		return is_callable([$this, 'myCallable']) ? $this->myCallable(...) : null;
+	}
+}
+
+class ChildOne extends BaseClass
+{
+	//
+}
+
+class ChildTwo extends BaseClass
+{
+	public function myCallable(): string
+	{
+		return 'I exist on child two.';
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -194,4 +194,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock`
`194`	`194`	`return null;`
`195`	`195`	`}`
`196`	`196`
	`197`	`+ public function isDummy(): TrinaryLogic`
	`198`	`+ {`
	`199`	`+ return TrinaryLogic::createNo();`
	`200`	`+ }`
	`201`	`+`
`197`	`202`	`}`
Original file line number	Diff line number	Diff line change
`@@ -183,4 +183,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock`
`183`	`183`	`return $this->reflection->getResolvedPhpDoc();`
`184`	`184`	`}`
`185`	`185`
	`186`	`+ public function isDummy(): TrinaryLogic`
	`187`	`+ {`
	`188`	`+ return $this->reflection->isDummy();`
	`189`	`+ }`
	`190`	`+`
`186`	`191`	`}`
Original file line number	Diff line number	Diff line change
`@@ -169,4 +169,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock`
`169`	`169`	`return null;`
`170`	`170`	`}`
`171`	`171`
	`172`	`+ public function isDummy(): TrinaryLogic`
	`173`	`+ {`
	`174`	`+ return TrinaryLogic::createYes();`
	`175`	`+ }`
	`176`	`+`
`172`	`177`	`}`
Original file line number	Diff line number	Diff line change
`@@ -161,4 +161,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock`
`161`	`161`	`return null;`
`162`	`162`	`}`
`163`	`163`
	`164`	`+ public function isDummy(): TrinaryLogic`
	`165`	`+ {`
	`166`	`+ return TrinaryLogic::createYes();`
	`167`	`+ }`
	`168`	`+`
`164`	`169`	`}`
Original file line number	Diff line number	Diff line change
`@@ -243,4 +243,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock`
`243`	`243`	`return $this->resolvedPhpDocBlock;`
`244`	`244`	`}`
`245`	`245`
	`246`	`+ public function isDummy(): TrinaryLogic`
	`247`	`+ {`
	`248`	`+ return TrinaryLogic::createNo();`
	`249`	`+ }`
	`250`	`+`
`246`	`251`	`}`
Original file line number	Diff line number	Diff line change
`@@ -213,4 +213,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock`
`213`	`213`	`return $this->nativeMethodReflection->getResolvedPhpDoc();`
`214`	`214`	`}`
`215`	`215`
	`216`	`+ public function isDummy(): TrinaryLogic`
	`217`	`+ {`
	`218`	`+ return TrinaryLogic::createNo();`
	`219`	`+ }`
	`220`	`+`
`216`	`221`	`}`
Original file line number	Diff line number	Diff line change
`@@ -172,4 +172,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock`
`172`	`172`	`return null;`
`173`	`173`	`}`
`174`	`174`
	`175`	`+ public function isDummy(): TrinaryLogic`
	`176`	`+ {`
	`177`	`+ return TrinaryLogic::createNo();`
	`178`	`+ }`
	`179`	`+`
`175`	`180`	`}`
Original file line number	Diff line number	Diff line change
`@@ -303,4 +303,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock`
`303`	`303`	`return $this->resolvedPhpDoc;`
`304`	`304`	`}`
`305`	`305`
	`306`	`+ public function isDummy(): TrinaryLogic`
	`307`	`+ {`
	`308`	`+ return TrinaryLogic::createNo();`
	`309`	`+ }`
	`310`	`+`
`306`	`311`	`}`
Original file line number	Diff line number	Diff line change
`@@ -485,4 +485,9 @@ public function getResolvedPhpDoc(): ?ResolvedPhpDocBlock`
`485`	`485`	`return $this->resolvedPhpDocBlock;`
`486`	`486`	`}`
`487`	`487`
	`488`	`+ public function isDummy(): TrinaryLogic`
	`489`	`+ {`
	`490`	`+ return TrinaryLogic::createNo();`
	`491`	`+ }`
	`492`	`+`
`488`	`493`	`}`