AutowiredParameter attribute#4042
Merged
ondrejmirtes merged 1 commit into2.1.xfrom Jun 4, 2025
Merged
Conversation
1759ff6 to
c3fcc8d
Compare
Contributor
|
root cause for the PHP 7.4 only CI errors is, that the transformed code contains lines like while for PHP7.x compat the attributes need to stay on there own line: |
Member
Author
|
I know. nikic/PHP-Parser 5.5.0 even addresses this, I think I'm setting it up correctly but it doesn't work yet. |
Contributor
|
narrowed it further down. it only happens in |
Member
Author
|
You don't need to look into it, I already solved it. |
c3fcc8d to
d8556bf
Compare
Member
Author
|
Blocked on #2955 + humbug/php-scoper#1122 |
0572f9e to
1d1c57c
Compare
1d1c57c to
40ff6ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.