Update RedisCluster signatures#4045
Update RedisCluster signatures#4045RobiNN1 wants to merge 2 commits intophpstan:2.1.xfrom RobiNN1:2.1.x
Conversation
|
Hey, this is too many changes and it's impossible to review. What actual bugs are you experiencing? We could also remove these entries altogether and just rely on phpstorm-stubs. "Reflection golden test" workflow will tell us what actual data would change. |
|
I added changes from from JetBrains/phpstorm-stubs@348c656 The current signatures are outdated, and more than 50 functions are missing. It was outdated in phpstorm stubs and here too |
|
I'm working on new PR and tried to keep the original parameter names, but the difference is still huge. The old signatures of many functions don't even have defined return types. |
|
Here's a PR where I'm removing all the signatures: #4055 Here are the changes in reflection data: https://github.com/phpstan/phpstan-src/actions/runs/15553088664/job/43787529381 You could go through them and maybe improve the stubs in phpstorm-stubs based on that so that we could remove the signatures on PHPStan's side. Thank you. |
I synchronized signatures with https://github.com/JetBrains/phpstorm-stubs/blob/master/redis/RedisCluster.php