Issue-Bot: Emit GitHub Action annotation when issues are affected#4326
Issue-Bot: Emit GitHub Action annotation when issues are affected#4326ondrejmirtes merged 10 commits intophpstan:2.1.xfrom
Conversation
49638aa to
c442163
Compare
c442163 to
feb5c69
Compare
|
@ondrejmirtes @VincentLanglet any opinion on this? is it acceptable? if so, I would cleanup the PR and we can give it a try. |
| // XXX debug test | ||
| $exitCode = self::EXIT_AFFECTS_ISSUES; |
There was a problem hiding this comment.
todo: remove this debug line, which atm enforce rendering of the github action annotation message
|
Personally I like it |
|
I like it too! The reason why it's not safe to post a comment is because the only event that has access to secrets is |
|
This pull request has been marked as ready for review. |
|
ok cool - lets give it a try then |
|
Awesome, thank you! |
with this PR we get a issue-bot 'pull request annotation' in the 'files changed' tab, which looks like:
this annotation is only visible when issue bot finds affected issues, otherwise no annotation is showing up.
intentionally I used a message type "notice" to get a gentle hint which distracts as less as possible.
Goal: make it more obvious when issue bot has helpful results. before this PR we sometimes missed to check the issue bot results as they are hidden deep in the github.com UI
triggered by a discussion in #4168 (comment)