Do not parse PR body to find issues to close#5046
Closed
takaram wants to merge 2 commits intophpstan:2.1.xfrom
Closed
Do not parse PR body to find issues to close#5046takaram wants to merge 2 commits intophpstan:2.1.xfrom
takaram wants to merge 2 commits intophpstan:2.1.xfrom
Conversation
Extracting linked issues from PR body is very hard as there are variety of syntaxes to link an issue. https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword We should use `closingIssuesReferences` instead.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Avoid `${{ ... }}` syntax inside `run:`
- Use mapfile command rather than `URL=( $(...) )`
Member
|
I wouldn't be doing this if it wasn't necessary. I'm aware of |
Contributor
Author
Ah, I misunderstood. Sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting linked issues from PR body is very hard as there are variety of syntaxes to link an issue.
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
Especially some PRs use
phpstan/phpstan#<issue number>format instead of the issue URL.We should use
closingIssuesReferencesinstead.