Skip to content

Added regression tests#5050

Merged
staabm merged 3 commits into
phpstan:2.1.xfrom
staabm:regress
Feb 26, 2026
Merged

Added regression tests#5050
staabm merged 3 commits into
phpstan:2.1.xfrom
staabm:regress

Conversation

@staabm

@staabm staabm commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

@phpstan-bot

Copy link
Copy Markdown
Collaborator

You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x.

@staabm staabm changed the base branch from 2.2.x to 2.1.x February 26, 2026 17:15
@staabm staabm marked this pull request as ready for review February 26, 2026 17:16
@phpstan-bot

Copy link
Copy Markdown
Collaborator

This pull request has been marked as ready for review.

@VincentLanglet

Copy link
Copy Markdown
Contributor

Fixed by #5048 then, did you understand why ?

The issue bot changes seems huge https://github.com/phpstan/phpstan-src/actions/runs/22438882001?pr=5048 not sure if there is more fix

@staabm

staabm commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

did you understand why ?

before #5048 when a ArrayDimFetch was specified, it was later on intersected with StaticTypeFactory::*OffsetAccessibleType() which downgraded explicit mixed arrays into implict mixed arrays because of new ArrayType(new MixedType(), new MixedType())

@staabm

staabm commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

The issue bot changes seems huge phpstan/phpstan-src/actions/runs/22438882001?pr=5048 not sure if there is more fix

I looked thru all of them, but I don't think these are fixed. they just changed errors

@staabm

staabm commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

the failling AttributeReflectionTest seems unrelated - same errors can be seen no 2.1.x already

@staabm staabm merged commit a805b84 into phpstan:2.1.x Feb 26, 2026
373 of 375 checks passed
@staabm staabm deleted the regress branch February 26, 2026 18:55
phpstan-bot pushed a commit to phpstan-bot/phpstan-src that referenced this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing type check on array if another item is the correct type Explicit mixed array becomes implicit in if statement

3 participants