Upgrade Dead Code Detector to 0.15.x#5160
Conversation
|
@janedbal fyi, it seem the new version requires more memory than the old one. a job which worked on 0.14.x now runs into a memory limit: |
|
We have planned improvements to the result cache which should help. I'd rather soon do the improvements and then upgrade this package. |
|
I analysed this on friday. See shipmonk-rnd/dead-code-detector#310. Using
And that is FAR beyond what DCD takes (becase that runs when child processes are long dead). So I'd say it is ok for collector-based rules to take MUCH more memory (below that sum) as it does not increase overall memory consumption which you typically care about (CI limits). But thanks to Also, regular projects are not affected by DCD memory at all (not even when you look at the main process, e.g. ShipMonk codebase main process takes about 4GB and DCD is only about 800 MB of that) - phpstan-src is an exception for some reason. Also, I can "fix" memory consumtion here in PHPStan by omitting that cache, but it makes no sense in real world. I can also make it configurable for you, but again - it makes no sense imo. |
|
thanks everyone. lets revisit after phpstan/phpstan#14074 was resolved |

#5135 but with conflicts resolved