Fix phpstan/phpstan#13674: infer non-empty-list after isset($list[$i])#5161
Closed
phpstan-bot wants to merge 2 commits intophpstan:2.1.xfrom
Closed
Fix phpstan/phpstan#13674: infer non-empty-list after isset($list[$i])#5161phpstan-bot wants to merge 2 commits intophpstan:2.1.xfrom
non-empty-list after isset($list[$i])#5161phpstan-bot wants to merge 2 commits intophpstan:2.1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes phpstan/phpstan#13674
When
isset($arr[$dim])is used with a non-constant dimension (e.g. a variable$i), PHPStan now correctly narrows the array type tonon-empty-array/non-empty-list.Previously,
isset($list[$i])would narrow the dim type but not the array itself. Now, if both the PHPDoc type and native type are arrays, the array is narrowed to non-empty in the truthy branch.The narrowing is guarded by checking that the native type is also an array, which prevents issues with template types in loop scope merging where the native type is
mixed.Examples