Skip to content

Fix phpstan/phpstan#14019: Assignment in a key of array destructuring is ignored #5164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 2 commits into from
Mar 9, 2026
Merged

Fix phpstan/phpstan#14019: Assignment in a key of array destructuring is ignored #5164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93eac04
Fix assignment in key of array destructuring being ignored
ondrejmirtes Mar 9, 2026
bb991b8
Update DefinedVariableRuleTest.php
staabm Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Analyser/ExprHandler/AssignHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ public function processAssignVar(
$throwPoints = array_merge($throwPoints, $keyResult->getThrowPoints());
$impurePoints = array_merge($impurePoints, $keyResult->getImpurePoints());
$isAlwaysTerminating = $isAlwaysTerminating || $keyResult->isAlwaysTerminating();
// no need for $keyResult->getScope()
Copy link
Copy Markdown
Contributor

@staabm staabm Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol ;)

$scope = $keyResult->getScope();
}

if ($arrayItem->key === null) {
Expand Down
10 changes: 10 additions & 0 deletions tests/PHPStan/Analyser/nsrt/bug-14019.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php declare(strict_types = 1);

namespace Bug14019;

use function PHPStan\Testing\assertType;

[($a = 'foo') => $b] = ['foo' => 1];

assertType("'foo'", $a);
assertType('1', $b);
10 changes: 10 additions & 0 deletions tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,6 +1393,16 @@ public function testBug6830(): void
$this->analyse([__DIR__ . '/data/bug-6830.php'], []);
}

public function testBug14019(): void
{
$this->cliArgumentsVariablesRegistered = true;
$this->polluteScopeWithLoopInitialAssignments = false;
$this->checkMaybeUndefinedVariables = true;
$this->polluteScopeWithAlwaysIterableForeach = true;

$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-14019.php'], []);
}

public function testBug14117(): void
{
$this->cliArgumentsVariablesRegistered = true;
Expand Down
Loading