Skip to content

IntersectionType: Prevent duplicate work in isOffsetAccessible() #5243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 1 commit into from
Mar 18, 2026
Merged

IntersectionType: Prevent duplicate work in isOffsetAccessible() #5243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Type/IntersectionType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ class IntersectionType implements CompoundType

private ?TrinaryLogic $isOversizedArray = null;

private ?TrinaryLogic $isOffsetAccessible = null;

private ?TrinaryLogic $isIterableAtLeastOnce = null;

private ?TrinaryLogic $isConstantScalarValue = null;
Expand Down Expand Up @@ -862,7 +864,7 @@ public function looseCompare(Type $type, PhpVersion $phpVersion): BooleanType

public function isOffsetAccessible(): TrinaryLogic
{
return $this->intersectResults(static fn (Type $type): TrinaryLogic => $type->isOffsetAccessible());
return $this->isOffsetAccessible ??= $this->intersectResults(static fn (Type $type): TrinaryLogic => $type->isOffsetAccessible());
}

public function isOffsetAccessLegal(): TrinaryLogic
Expand Down
Loading