-
Notifications
You must be signed in to change notification settings - Fork 572
Fix phpstan/phpstan#11054: [NAN] === mixed is always evaluated as false #5321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
staabm
merged 2 commits into
phpstan:2.1.x
from
phpstan-bot:create-pull-request/patch-2yr80xg
Mar 29, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <?php declare(strict_types = 1); | ||
|
|
||
| namespace Bug11054; | ||
|
|
||
| class XXX { | ||
| public const DEF_VALUE = [NAN]; | ||
| public const NO_VALUE = [NAN]; | ||
| } | ||
|
|
||
| class YYY | ||
| { | ||
| public const LOSSLESS = [NAN]; | ||
|
|
||
| /** | ||
| * @param string|int|mixed $substituteChar | ||
| */ | ||
| public static function convertEncoding ( | ||
| string $str, | ||
| string $sourceEncoding, | ||
| string $targetEncoding, | ||
| $substituteChar = XXX::DEF_VALUE, | ||
| $defValue = XXX::NO_VALUE | ||
| ): string { | ||
| if ($substituteChar === XXX::DEF_VALUE) { // no error expected | ||
| return mb_convert_encoding($str, $targetEncoding, $sourceEncoding); | ||
| } | ||
|
|
||
| if ($substituteChar === self::LOSSLESS) { // no error expected | ||
| return $str; | ||
| } | ||
|
|
||
| return $str; | ||
| } | ||
| } | ||
|
|
||
| class InfTest { | ||
| public const DEF_VALUE = [INF]; | ||
| public const NO_VALUE = [INF]; | ||
|
|
||
| /** @param mixed $v */ | ||
| public static function test($v): void | ||
| { | ||
| if ($v === self::DEF_VALUE) { // no error expected | ||
| return; | ||
| } | ||
|
|
||
| if ($v === self::NO_VALUE) {} // error expected - INF === INF is true, so narrowing is correct | ||
| } | ||
| } | ||
|
|
||
| class SimpleTest { | ||
| /** @param mixed $v */ | ||
| public static function test($v): void | ||
| { | ||
| if ($v === [NAN]) {} // no error expected | ||
| if ($v === [INF]) {} // no error expected | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another test using INF instead of NAN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both background tasks confirmed complete. All done — the commit with INF test cases has been pushed to the PR branch.