Fix phpstan/phpstan#14393: Does not warn about non-nullable class-property by phpstan-bot · Pull Request #5327 · phpstan/phpstan-src

phpstan-bot · 2026-03-29T11:15:12Z

Summary

PHPStan did not warn about using ?? on non-nullable native-typed instance properties accessed on objects other than $this. For example, $o->i ?? -1 where $i is public int $i = 10 produced no warning, even though the type is int (not nullable).

Changes

Modified src/Rules/IssetCheck.php to only bail out of the native-typed property check for $this->prop access (where initialization tracking matters) and static properties (where lazy initialization via ??= is a valid pattern). Non-$this instance property access now falls through to the normal type check.
Updated tests/PHPStan/Rules/Variables/NullCoalesceRuleTest.php — the ReflectionClass::$name warning is now expected on all PHP versions (previously only PHP < 8.1).
Updated tests/PHPStan/Rules/Variables/IssetRuleTest.php — native-typed instance properties on external objects now all produce warnings.
Fixed src/Type/Php/ArrayFindFunctionReturnTypeExtension.php — removed unnecessary ?? null on PhpParser\Node\Arg::$value which is always non-null.
Added regression test tests/PHPStan/Rules/Variables/data/bug-14393.php.

Root cause

In IssetCheck::check(), when a property had a native type and the scope didn't explicitly track the expression type ($scope->hasExpressionType($expr)->yes() was false), the code bailed out early for ALL property accesses. This was intended to handle potentially uninitialized typed properties, but it was too conservative — it also suppressed warnings for instance property access on external objects where PHPStan resolves the type as non-nullable.

The fix narrows the bail-out to only apply to:

$this->prop — where PHPStan tracks initialization state and the bail-out prevents false positives for possibly-uninitialized properties
Static properties — where ??= is commonly used for lazy initialization

Test

Added tests/PHPStan/Rules/Variables/data/bug-14393.php which tests $o->i ?? -1 where $i is public int $i = 10. The expected error is: "Property Bug14393\MyClass::$i (int) on left side of ?? is not nullable."

Fixes phpstan/phpstan#14393
Closes phpstan/phpstan#4846

VincentLanglet

Add test for

public int $i;

phpstan-bot · 2026-03-29T11:35:02Z

Done. Here's what I changed to address the review:

Added test for public int $i; (no default value) in bug-14393.php — a MyClassUninitialized class with an uninitialized typed property. Using $o2->i ?? -1 should NOT produce a warning since the property could be uninitialized.
Fixed IssetCheck.php — for non-$this instance property fetches on native-typed properties without a default value (hasDefaultValue() === false), we now bail out instead of reporting a false positive. Properties without defaults can be uninitialized when accessed on external objects, making ?? valid.
Updated test expectations — removed the ReflectionClass::$name warning (it has no default value, set in constructor) and the $canBeUninitialized isset warning (also no default value).

VincentLanglet

Add test for

$this->i ?? -1

inside both MyClass and MyClassUninitialized

phpstan-bot · 2026-03-29T11:57:40Z

make tests also passed. Both make phpstan and make tests completed successfully with no regressions.

The commit has already been pushed. The review request has been addressed — $this->i ?? -1 tests are now included inside both MyClass (initialized) and MyClassUninitialized (uninitialized), confirming that neither produces a false positive warning for $this->prop access.

VincentLanglet

Add test for

	/** @var int */
	public $i;

and for

	public ?int $i;

and for

	public ?int $i = 10;

and for

	public ?int $i = null;

phpstan-bot · 2026-03-29T13:57:47Z

make tests also confirmed complete — 11687 tests, all passing. The commit with the reviewer's requested test cases has been pushed.

VincentLanglet · 2026-03-29T14:29:10Z

-		if (PHP_VERSION_ID < 80100) {
-			$errors[] = [
-				'Property ReflectionClass<object>::$name (class-string<object>) on left side of ?? is not nullable.',
-				136,
-			];
-		}


Revert this change

make tests also passed — all 11687 tests green. The review feedback has been fully addressed, committed, and pushed.

VincentLanglet

Add non regression test for phpstan/phpstan#4846

phpstan-bot · 2026-03-29T14:38:30Z

Already handled — make tests passed (11688 tests, all green). Everything has been pushed.

VincentLanglet · 2026-03-29T15:02:20Z

I was not sure about the phpdoc case but it's already reported https://phpstan.org/r/190c6781-3043-4ccd-bcf6-9bf2a37b3d91.

Maybe you'll see more test to add but this seems ok to me @staabm

… instance properties - Removed bail-out in IssetCheck for native-typed instance properties accessed on non-$this objects - Static properties still bail out (valid lazy initialization pattern with ??=) - $this->prop still respects initialization tracking as before - Updated NullCoalesceRuleTest to always expect warning for ReflectionClass::$name - Updated IssetRuleTest to expect warnings for all native-typed instance properties - Removed unnecessary ?? null in ArrayFindFunctionReturnTypeExtension - New regression test in tests/PHPStan/Rules/Variables/data/bug-14393.php

Properties declared as `public int $i;` (without a default value) can be uninitialized when accessed on external objects, so using ?? on them is valid. Only warn when the property has a default value (guaranteed initialized). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ized Addresses review feedback: tests verify that $this->prop access inside the class does not produce false positive warnings for either initialized or uninitialized typed properties. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

For $this->prop access on native-typed properties with a default value, the property is always initialized so ?? on non-nullable types is useless. Only skip the warning for $this->prop when the property has no default value (could be uninitialized). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@var

…ties Tests requested by reviewer: `/** @var int */ public $i`, `public ?int $i`, `public ?int $i = 10`, and `public ?int $i = null` — both for $this->prop and external object access. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ReflectionClass::$name has no default value (set in constructor), so on PHP >= 8.1 hasDefaultValue() returns false and the warning is correctly suppressed. Restore the PHP_VERSION_ID < 80100 guard. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add tests for isset($this->i) and isset($o->i) across all property variants (initialized, uninitialized, PHPDoc-only, nullable, etc.) as requested by reviewer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

staabm · 2026-03-30T06:26:29Z

+
+	public function doFoo(): void
+	{
+		var_dump(self::$i ?? -1);


we are missing a error here, because the static property referenced by self::$i is not nullable

Done. The fix applies the same hasDefaultValue() check to static properties that was already in place for instance properties. Now self::$i ?? -1 and isset(self::$i) correctly report errors when the static property has a native type and a default value (like public static int $i = 10), while still allowing the bail-out for uninitialized static properties (no default value) or dynamic class references.

Static properties with a native type and a default value (e.g. `public static int $i = 10`) should produce warnings for `self::$i ?? -1` and `isset(self::$i)` since the property is not nullable. Previously all static property fetches were exempt from this check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…l-out When the scope doesn't track the expression type for a native-typed property access, check if $expr->var is undefined before falling through to the type check. This prevents reporting "not nullable" errors when the real issue is an undefined variable. The check only bails out when there's an actual undefined error (non-null return), otherwise falls through to the normal type check. Same pattern applied to StaticPropertyFetch for consistency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

VincentLanglet · 2026-03-30T09:03:17Z

I was able to remove both checkUndefined done in this situation without breaking any test.
I didn't succeed writing a test which fail (missing an undefined test).

I'm ok merging this like this (and maybe waiting for a missing error report) but maybe you'll want to try producing an error/addind extra test.
Feel free to merge it if/when it's ok to you @staabm

staabm · 2026-03-30T09:08:18Z

love it. thank you

…perty (phpstan#5327) Co-authored-by: VincentLanglet <9052536+VincentLanglet@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Vincent Langlet <vincentlanglet@hotmail.fr>

VincentLanglet reviewed Mar 29, 2026

View reviewed changes

Comment thread tests/PHPStan/Rules/Variables/data/bug-14393.php

VincentLanglet reviewed Mar 29, 2026

View reviewed changes

VincentLanglet approved these changes Mar 29, 2026

View reviewed changes

VincentLanglet requested a review from staabm March 29, 2026 15:14

staabm reviewed Mar 29, 2026

View reviewed changes

Comment thread tests/PHPStan/Rules/Variables/data/bug-14393.php

staabm reviewed Mar 29, 2026

View reviewed changes

Comment thread tests/PHPStan/Rules/Variables/data/bug-14393.php

VincentLanglet and others added 10 commits March 30, 2026 08:25

Add non-regression test for phpstan/phpstan#4846

edda580

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add isset() tests for bug-14393

16b081f

Add tests for isset($this->i) and isset($o->i) across all property variants (initialized, uninitialized, PHPDoc-only, nullable, etc.) as requested by reviewer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add empty() tests for bug-14393

bb1614f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add static property tests for bug-14393

8ab2b3c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

staabm force-pushed the create-pull-request/patch-831pof2 branch from 8f7b91f to 8ab2b3c Compare March 30, 2026 06:25

staabm reviewed Mar 30, 2026

View reviewed changes

staabm approved these changes Mar 30, 2026

View reviewed changes

staabm requested a review from VincentLanglet March 30, 2026 06:35

Try simplify

b930602

VincentLanglet reviewed Mar 30, 2026

View reviewed changes

Comment thread src/Rules/IssetCheck.php

phpstan-bot and others added 2 commits March 30, 2026 08:08

Try

db7846d

staabm merged commit 2f58f5f into phpstan:2.1.x Mar 30, 2026
652 of 654 checks passed

staabm deleted the create-pull-request/patch-831pof2 branch March 30, 2026 09:08

This was referenced Mar 30, 2026

Does not warn about non-nullable class-property phpstan/phpstan#14393

Closed

Useless null coalesce not reported when relying on class property typehint phpstan/phpstan#4846

Closed

Conversation

phpstan-bot commented Mar 29, 2026 • edited by VincentLanglet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Root cause

Test

Uh oh!

VincentLanglet left a comment

Choose a reason for hiding this comment

Uh oh!

phpstan-bot commented Mar 29, 2026

Uh oh!

VincentLanglet left a comment

Choose a reason for hiding this comment

Uh oh!

phpstan-bot commented Mar 29, 2026

Uh oh!

Uh oh!

VincentLanglet left a comment

Choose a reason for hiding this comment

Uh oh!

phpstan-bot commented Mar 29, 2026

Uh oh!

VincentLanglet Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

phpstan-bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

VincentLanglet left a comment

Choose a reason for hiding this comment

Uh oh!

phpstan-bot commented Mar 29, 2026

Uh oh!

VincentLanglet commented Mar 29, 2026

Uh oh!

Uh oh!

Uh oh!

staabm Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

phpstan-bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VincentLanglet commented Mar 30, 2026

Uh oh!

staabm commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

phpstan-bot commented Mar 29, 2026 •

edited by VincentLanglet

Loading