-
Notifications
You must be signed in to change notification settings - Fork 568
Fix phpstan/phpstan#12686: Unable to mark an anonymous function as impure #5348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
VincentLanglet
merged 5 commits into
phpstan:2.1.x
from
phpstan-bot:create-pull-request/patch-q3t395n
Mar 30, 2026
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dbdc192
Fix phpstan/phpstan#12686: Respect closure purity in type narrowing
github-actions[bot] 2464761
Add tests for multiple callable parameter acceptors purity check
phpstan-bot 93e1e21
Add regression tests for phpstan/phpstan#3770 and phpstan/phpstan#6822
phpstan-bot b788e4e
Add rule test for phpstan/phpstan#6822 to prove no false-positive rul…
phpstan-bot a811e24
Reuse nsrt/bug-6822.php for rule test instead of separate data file
phpstan-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?php declare(strict_types = 1); | ||
|
|
||
| namespace Bug12686; | ||
|
|
||
| use function PHPStan\Testing\assertType; | ||
|
|
||
| /** @phpstan-impure */ | ||
| $f = function (): bool { | ||
| return (bool) rand(0,1); | ||
| }; | ||
|
|
||
| if ($f()) { | ||
| assertType('bool', $f()); | ||
| } | ||
|
|
||
| // Pure closure should still have narrowing | ||
| $h = function (): bool { | ||
| return true; | ||
| }; | ||
|
|
||
| if ($h()) { | ||
| assertType('true', $h()); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.