Fix phpstan/phpstan#14407: !in_array with enum values incorrectly narrows to NEVER#5365

Merged

VincentLanglet merged 15 commits intophpstan:2.1.xfrom

phpstan-bot:create-pull-request/patch-k4otjc0

Apr 1, 2026

Commits on Apr 1, 2026

Fix phpstan/phpstan#14407: !in_array with enum values incorrectly narrows to *NEVER*

phpstan-bot
authored and
staabm
committed
Refactor: use single TypeCombinator::intersect call for performance

authored and
staabm
committed
Handle optional keys in constant arrays for !in_array narrowing

authored and
staabm
committed
Refactor: defer narrowing computation to avoid unnecessary work in !in_array

authored and
staabm
committed
Refactor: extract computeGuaranteedValueType private method

authored and
staabm
committed
Refactor: extract computeNeedleNarrowingType to unify true/false context logic

authored and
staabm
committed
Refactor: inline computeGuaranteedValueType into computeNeedleNarrowingType

authored and
staabm
committed
Return null instead of fallback to $arrayValueType when $innerValueTypes is empty

authored and
staabm
committed
Refactor: use Type::getArrays() instead of manual union decomposition

authored and
staabm
committed
Skip narrowing for non-constant arrays with multiple possible value types

authored and
staabm
committed
Rework

VincentLanglet
authored and
staabm
committed
Add instanceof ConstantArrayType to phpstan baseline

authored and
staabm
committed
Add non-regression tests for phpstan/phpstan#13421 and phpstan/phpstan#8864

authored and
staabm
committed
Remove comment

VincentLanglet
authored and
staabm
committed
Add non-regression rule tests for strict comparison false positives

authored and
staabm
committed