Fix phpstan/phpstan#14073: Performance - list the most-often-analysed trait files in -vvv (DiagnoseExtension)

[phpstan-bot]

Implements the feature requested in phpstan/phpstan#14073: when running PHPStan with -vvv, the diagnostic output now includes the top 5 most-often-analysed files (typically trait files). This helps detect performance issues like the one found in Shopware where trait files were analysed an excessive number of times.

Fixes phpstan/phpstan#14073

---

running this PR on wordpress-develop

➜  wordpress-develop git:(trunk) ../../bin/phpstan analyze src -vvv
Note: Using configuration file /Users/staabm/workspace/phpstan-src/tmp/wordpress-develop/phpstan.neon.dist.
Result cache not used because the metadata do not match: phpstanVersion, projectConfig
 1512/1512 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 21 secs/21 secs

Result cache is saved.

                                                                                                                        
 [OK] No errors                                                                                                         
                                                                                                                        

PHP runtime version: 8.3.30
PHP version for analysis: 7.4-8.5 (from config)

PHPStan version: 2.1.x-dev@a857004
PHPStan running from:
../../bin/phpstan

Extension installer: Not installed

Discovered Composer project root:
/Users/staabm/workspace/phpstan-src/tmp/wordpress-develop

Most often analysed files:
  src/wp-includes/php-ai-client/src/Providers/Http/Traits/WithHttpTransporterTrait.php: 4 times
  src/wp-includes/php-ai-client/src/Providers/Http/Traits/WithRequestAuthenticationTrait.php: 3 times
  src/wp-includes/php-ai-client/src/Common/Traits/WithDataCachingTrait.php: 2 times

Parallel processing scheduler:
# of detected CPU cores:   14
# of analysed files:       1512
# of jobs:                 76
# of spawned processes:    8

Elapsed time: 21.36 seconds
Used memory: 3.98 GB

[VincentLanglet]

I just wonder if a new feature like this should be approved by ondrej @staabm.

Also if we should directly count in the addProcessedFiles to reduce the memory consuption in case there is lot of duplicated files.

[staabm]

Also if we should directly count in the addProcessedFiles to reduce the memory consuption in case there is lot of duplicated files.

I think we cannot save much because the path strings are already allocated at the analyzer level and collecting them in an array shouldn't add much more.

[staabm]

instead of having this separate DiagnoseExtension the logic could be merged into PHPStanDiagnoseExtension

[VincentLanglet]

Not sure if it was meant to the bot, but I don't think it handle this feedback since you approved the PR

[staabm]

Yeah that was intentional

[phpstan-bot]

The make tests background task also completed successfully. All checks pass.

[phpstan-bot]

The changes are already pushed to the remote. The commit 023dddf0b contains exactly the same changes I made — merging ProcessedFilesDiagnoseExtension into PHPStanDiagnoseExtension, updating the service config, and removing the separate class and its test.

The review feedback from staabm has been addressed:

• Removed the separate ProcessedFilesDiagnoseExtension class
• Merged the "most often analysed files" diagnostic output into PHPStanDiagnoseExtension
• Added ProcessedFilesCollector and RelativePathHelper as constructor dependencies
• Updated conf/services.neon to pass simpleRelativePathHelper
• Removed the now-unnecessary test file
• Both make phpstan and make tests pass cleanly

[VincentLanglet]

I think it handles the comment because of me @staabm #5395 (comment)
I think that answering to a review retrigger the bot (even if the initial message was an approval)

Do you want to revert it then?

[staabm]

Lets wait for ondrejs opinion