Fix ObjectType::equals

[VincentLanglet]

#5398 shows the behavior before

Closes phpstan/phpstan#3028
Closes phpstan/phpstan#14429
Closes phpstan/phpstan#5298

Failures:

• nextra/orm https://github.com/phpstan/phpstan-src/actions/runs/23979232001/job/69941215879?pr=5399 => This seems justified to me, as proven by the non regression test added ; Prior to this fix we had an inconsistency in the error reported Add non regression test #5398

• rector/downgrade https://github.com/phpstan/phpstan-src/actions/runs/23979232001/job/69941215795?pr=5399 => Explain by Fix ObjectType::equals #5399 (comment)

• rector https://github.com/phpstan/phpstan-src/actions/runs/23979232001/job/69941215804?pr=5399 => Explain by Fix ObjectType::equals #5399 (comment)

• rector/src https://github.com/phpstan/phpstan-src/actions/runs/23979232001/job/69941215874?pr=5399 => I think '#Provide more specific return type "Iterator" over abstract one#' is reported because before, new ObjectType(Iterator) was equals to new GenericObject(Iterator), which not now. I would say it need to be fix on rector codebase

I reported the issue on rector side rectorphp/rector#9729

[VincentLanglet]

I'm breaking rector because they have multiple class extending the ObjectType like https://github.com/rectorphp/rector/blob/8e733dbcc4fe72493e533d354e195d77c7baee07/src/StaticTypeMapper/ValueObject/Type/FullyQualifiedObjectType.php#L15

Which rely on the ObjectType::equals method.

And some rules from rector are relying on the fact that ObjectType::equals(FullyQualifiedObjectType) is true for instance.

[ondrejmirtes]

Yes, don't worry about it

[VincentLanglet]

Yes, don't worry about it

@ondrejmirtes Does it means we prefer the "right" fix get_class($type) !== static::class, and we'll ask rector to update their implementation
Or should we choose the instanceof checks (aa95f94) to imply as few change as possible in rector codebase.

I do understand you prefer the get_class($type) !== static::class ?

[VincentLanglet]

TODO:

• Adding non regression tests https://github.com/phpstan/phpstan-src/actions/runs/23980124209?pr=5399
• Adding more Unit test on ObjectType::equals

[ondrejmirtes]

Yes, I prefer get_class($type) !== static::class. Rector's code is just wrong.

[phpstan-bot]

This pull request has been marked as ready for review.

[staabm]

I think we did a similar fix in MixedType/ErrorType in the past.

ed7eb47