Skip to content

Fix phpstan/phpstan#13325: RegexIterator returns a generic type with unknown parameters #5403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phpstan-bot wants to merge 2 commits into from
Closed

Fix phpstan/phpstan#13325: RegexIterator returns a generic type with unknown parameters #5403

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a0950f
Fix RegexIterator returning generic type with unresolved template par…
VincentLanglet Apr 5, 2026
57ed5a4
Use TIterator as RegexIterator constructor param type to enable full …
phpstan-bot Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Analyser/Traverser/GenericTypeTemplateTraverser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function traverse(Type $type, callable $traverse): Type
if ($type instanceof TemplateType && !$type->isArgument()) {
$newType = $this->resolvedTemplateTypeMap->getType($type->getName());
if ($newType === null || $newType instanceof ErrorType) {
return $type->getDefault() ?? $type->getBound();
return $traverse($type->getDefault() ?? $type->getBound());
}

return TemplateTypeHelper::generalizeInferredTemplateType($type, $newType);
Expand Down
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/Methods/ReturnTypeRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,4 +1326,9 @@ public function testBug10924(): void
$this->analyse([__DIR__ . '/data/bug-10924.php'], []);
}

public function testBug13325(): void
{
$this->analyse([__DIR__ . '/data/bug-13325.php'], []);
}

}
18 changes: 18 additions & 0 deletions tests/PHPStan/Rules/Methods/data/bug-13325.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

declare(strict_types=1);

namespace Bug13325;

use Iterator;
use RegexIterator;
use Traversable;

final class Foo
{
/** @return RegexIterator<mixed, mixed, Traversable<mixed, mixed>> */
public function __invoke(Iterator $iterator): RegexIterator
{
return new RegexIterator($iterator, 'string');
}
}
Loading