Skip to content

Fix phpstan/phpstan#12063: Call to function is_callable() with array{...} will always evaluate to true #5409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 5 commits into from
Apr 7, 2026
Merged

Fix phpstan/phpstan#12063: Call to function is_callable() with array{...} will always evaluate to true #5409

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a936524
Fix phpstan/phpstan#12063: is_callable() false positive with union me…
VincentLanglet Apr 6, 2026
33171cd
Remove unused $hasNonExistentMethod variable in findTypeAndMethodNames()
phpstan-bot Apr 6, 2026
3e442f2
Add non-regression tests for phpstan/phpstan#4608
phpstan-bot Apr 6, 2026
784b42b
Fix call_user_func parameter name for PHP 7.4 compatibility
phpstan-bot Apr 6, 2026
01b2144
Fix coding standard: use sprintf() instead of variable in double-quot…
phpstan-bot Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/Type/Constant/ConstantArrayType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,8 @@ public function equals(Type $type): bool

public function isCallable(): TrinaryLogic
{
$typeAndMethods = $this->findTypeAndMethodNames();
$hasNonExistentMethod = false;
$typeAndMethods = $this->doFindTypeAndMethodNames($hasNonExistentMethod);
if ($typeAndMethods === []) {
return TrinaryLogic::createNo();
}
Expand All @@ -504,7 +505,13 @@ public function isCallable(): TrinaryLogic
$typeAndMethods,
);

return TrinaryLogic::createYes()->and(...$results);
$result = TrinaryLogic::createYes()->and(...$results);

if ($hasNonExistentMethod) {
$result = $result->and(TrinaryLogic::createMaybe());
}

return $result;
}

public function getCallableParametersAcceptors(ClassMemberAccessAnswerer $scope): array
Expand Down Expand Up @@ -537,6 +544,13 @@ public function getCallableParametersAcceptors(ClassMemberAccessAnswerer $scope)

/** @return ConstantArrayTypeAndMethod[] */
public function findTypeAndMethodNames(): array
{
$hasNonExistentMethod = false;
Copy link
Copy Markdown
Contributor

@VincentLanglet VincentLanglet Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to instantiate this variable since we don't use it ?

Copy link
Copy Markdown
Collaborator Author

@phpstan-bot phpstan-bot Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Made the $hasNonExistentMethod parameter optional with a default value of false in doFindTypeAndMethodNames(), so findTypeAndMethodNames() no longer needs to instantiate a variable it never uses. All tests and static analysis pass.

return $this->doFindTypeAndMethodNames($hasNonExistentMethod);
}

/** @return ConstantArrayTypeAndMethod[] */
private function doFindTypeAndMethodNames(bool &$hasNonExistentMethod): array
{
if (count($this->keyTypes) !== 2) {
return [];
Expand Down Expand Up @@ -578,6 +592,7 @@ public function findTypeAndMethodNames(): array
foreach ($methods->getConstantStrings() as $methodName) {
$has = $type->hasMethod($methodName->getValue());
if ($has->no()) {
$hasNonExistentMethod = true;
continue;
}

Expand Down
6 changes: 6 additions & 0 deletions tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,4 +1214,10 @@ public function testBug13799(): void
]);
}

public function testBug12063(): void
{
$this->treatPhpDocTypesAsCertain = true;
$this->analyse([__DIR__ . '/data/bug-12063.php'], []);
}

}
38 changes: 38 additions & 0 deletions tests/PHPStan/Rules/Comparison/data/bug-12063.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<?php declare(strict_types=1);

namespace Bug12063;

use BadFunctionCallException;

final class View
{
public function existingMethod(): void
{
}
}

final class TwigExtension
{
private View $viewFunctions;

public function __construct(View $viewFunctions)
{
$this->viewFunctions = $viewFunctions;
}

public function iterateFunctions(): void
{
$functionMappings = [
'i_exist' => 'existingMethod',
'i_dont_exist' => 'nonExistingMethod'
];

$functions = [];
foreach ($functionMappings as $nameFrom => $nameTo) {
$callable = [$this->viewFunctions, $nameTo];
if (!is_callable($callable)) {
throw new BadFunctionCallException("Function $nameTo does not exist in view functions");
}
}
}
}
Loading