Fix phpstan/phpstan#9844: Calling a static method over non-generic class-string results in ErrorType

src/Rules/Methods/StaticMethodCallCheck.php

@@ -24,8 +24,10 @@
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\TrinaryLogic;
+use PHPStan\Type\ClassStringType;
 use PHPStan\Type\ErrorType;
 use PHPStan\Type\Generic\GenericClassStringType;
+use PHPStan\Type\ObjectWithoutClassType;
 use PHPStan\Type\StaticType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
@@ -200,11 +202,14 @@ public function check(
 			if (!$classType->isObject()->yes()) {
 				return [[], null];
 			}
+		} elseif ($classType instanceof ClassStringType) { // @phpstan-ignore phpstanApi.instanceofType
+			$typeForDescribe = $classType;
+			$classType = new ObjectWithoutClassType();
 		} elseif ($classType->isString()->yes()) {
 			return [[], null];
 		}
 
-		$typeForDescribe = $classType;
+		$typeForDescribe ??= $classType;
 		if ($classType instanceof StaticType) {
 			$typeForDescribe = $classType->getStaticObjectType();
 		}

tests/PHPStan/Analyser/nsrt/bug-9844.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types = 1);
+
+namespace Bug9844;
+
+use function PHPStan\Testing\assertType;
+
+class HelloWorld
+{
+
+	/**
+	 * @param class-string $class
+	 */
+	public function sayHello(string $class): void
+	{
+		assertType('*ERROR*', $class::foo());
+	}
+}

tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php

@@ -243,6 +243,10 @@ public function testCallStaticMethods(): void
 				'Static call to instance method CallStaticMethods\InterfaceWithStaticMethod::doInstanceFoo().',
 				213,
 			],
+			[
+				'Call to an undefined static method class-string::nonexistentMethod().',
+				295,
+			],
 			[
 				'Static method CallStaticMethods\Foo::test() invoked with 3 parameters, 0 required.',
 				298,
@@ -1009,4 +1013,21 @@ public function testPipeOperator(): void
 		]);
 	}
 
+	public function testBug9844(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkExplicitMixed = false;
+		$this->checkImplicitMixed = false;
+		$this->analyse([__DIR__ . '/data/bug-9844.php'], [
+			[
+				'Call to an undefined static method class-string::foo().',
+				13,
+			],
+			[
+				'Call to an undefined static method object::foo().',
+				21,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-9844.php

@@ -0,0 +1,23 @@
+<?php declare(strict_types = 1);
+
+namespace Bug9844;
+
+class HelloWorld
+{
+
+	/**
+	 * @param class-string $class
+	 */
+	public function sayHello(string $class): void
+	{
+		$class::foo();
+	}
+
+	/**
+	 * @param object $class
+	 */
+	public function sayHello2(object $class): void
+	{
+		$class::foo();
+	}
+}