Make bcround pure

[still-dreaming-1]

No description provided.

[VincentLanglet]

You have to run ./bin/generate-function-metadata.php in order to update also resources/functionMetadata

[still-dreaming-1]

You have to run ./bin/generate-function-metadata.php in order to update also resources/functionMetadata

Ok, thanks. I will try it on my machine. My initial attempt was an edit straight from GitHub.

[VincentLanglet]

You have to run ./bin/generate-function-metadata.php in order to update also resources/functionMetadata

Ok, thanks. I will try it on my machine. My initial attempt was an edit straight from GitHub.

Editing manually the second file manually might work too.

[ondrejmirtes]

Never manually edit a generated file 😊

[still-dreaming-1]

Never manually edit a generated file 😊

Good point. I already did, and messed it up, and then hopefully fixed it...

[still-dreaming-1]

I guess if you think it's good enough, you can merge it. Otherwise if you close this without merging I can start over and try it locally on my system. If I do it locally on my system, do I need to install php 8.2? I currently have 8.5.5.

[VincentLanglet]

I ran it

[staabm]

@still-dreaming-1 could you give us an example how you find out that bcround is not pure and what impact you expect from this PR?

[staabm]

(I am asking, because the PR as is does e.g. not resolve https://phpstan.org/r/abbea322-e316-4be5-8f15-e2d9f6db4a70)

[still-dreaming-1]

(I am asking, because the PR as is does e.g. not resolve https://phpstan.org/r/abbea322-e316-4be5-8f15-e2d9f6db4a70)

That is a good example of what I'm wanting to be able to do without that issue. I would have used @phpstan-pure unless @pure does the same thing (I guess it does or else the issue would not appear...). The next time I do a PR I will try to do it locally on my system and try to test if it resolves my issue or not.

[staabm]

I would have used @phpstan-pure unless @pure does the same thing (I guess it does or else the issue would not appear...).

yes. its the same thing.

---

I just realized the error in my testing.

bcround is only available in PHP 8.4+ and I tested on 8.3.

the PR is fine, thanks