Skip to content

Declare multiple apcu_ functions as impure #5516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 1 commit into from
Apr 23, 2026
+53 −1
Merged

Declare multiple apcu_ functions as impure #5516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions bin/functionMetadata_original.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,20 @@
'acosh' => ['hasSideEffects' => false],
'addcslashes' => ['hasSideEffects' => false],
'addslashes' => ['hasSideEffects' => false],
'apcu_add' => ['hasSideEffects' => true],
'apcu_cache_info' => ['hasSideEffects' => true],
'apcu_cas' => ['hasSideEffects' => true],
'apcu_clear_cache' => ['hasSideEffects' => true],
'apcu_dec' => ['hasSideEffects' => true],
'apcu_delete' => ['hasSideEffects' => true],
'apcu_enabled' => ['hasSideEffects' => true],
'apcu_entry' => ['hasSideEffects' => true],
'apcu_exists' => ['hasSideEffects' => true],
'apcu_fetch' => ['hasSideEffects' => true],
'apcu_inc' => ['hasSideEffects' => true],
'apcu_key_info' => ['hasSideEffects' => true],
'apcu_sma_info' => ['hasSideEffects' => true],
'apcu_store' => ['hasSideEffects' => true],
'array_change_key_case' => ['hasSideEffects' => false],
'array_chunk' => ['hasSideEffects' => false],
'array_column' => ['hasSideEffects' => false],
Expand Down
16 changes: 15 additions & 1 deletion resources/functionMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,20 @@
'apache_get_version' => ['hasSideEffects' => false],
'apache_getenv' => ['hasSideEffects' => false],
'apache_request_headers' => ['hasSideEffects' => false],
'apcu_add' => ['hasSideEffects' => true],
'apcu_cache_info' => ['hasSideEffects' => true],
'apcu_cas' => ['hasSideEffects' => true],
'apcu_clear_cache' => ['hasSideEffects' => true],
'apcu_dec' => ['hasSideEffects' => true],
'apcu_delete' => ['hasSideEffects' => true],
'apcu_enabled' => ['hasSideEffects' => true],
'apcu_entry' => ['hasSideEffects' => true],
'apcu_exists' => ['hasSideEffects' => true],
'apcu_fetch' => ['hasSideEffects' => true],
'apcu_inc' => ['hasSideEffects' => true],
'apcu_key_info' => ['hasSideEffects' => true],
'apcu_sma_info' => ['hasSideEffects' => true],
'apcu_store' => ['hasSideEffects' => true],
'array_change_key_case' => ['hasSideEffects' => false],
'array_chunk' => ['hasSideEffects' => false],
'array_column' => ['hasSideEffects' => false],
Expand Down Expand Up @@ -1744,4 +1758,4 @@
'zlib_encode' => ['hasSideEffects' => false],
'zlib_get_coding_type' => ['hasSideEffects' => false],

];
];
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,4 +1197,9 @@ public function testBug14446(): void
$this->analyse([__DIR__ . '/../../Analyser/data/bug-14446.php'], []);
}

public function testBug14473(): void
{
$this->analyse([__DIR__ . '/data/bug-14519.php'], []);
}

}
19 changes: 19 additions & 0 deletions tests/PHPStan/Rules/Comparison/data/bug-14519.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types = 1);

namespace Bug14519;

$entry = apcu_fetch("key1");

if ($entry === false) {
die();
}

// assume long-running task when $entry exists

// re-fetch key "key1" again (it probably has been changed or deleted in the meantime by another process)
$entry = apcu_fetch("key1");

// phpstan complains here, but it shouldn't
if ($entry === false) {
die();
}
Loading