Update phpstorm stubs#5533
Merged
Merged
Conversation
VincentLanglet
force-pushed
the
updatePhpstorm
branch
from
April 25, 2026 19:43
36f9b49 to
7c7d940
Compare
VincentLanglet
force-pushed
the
updatePhpstorm
branch
from
April 25, 2026 20:58
36668fc to
387d332
Compare
staabm
reviewed
Apr 27, 2026
| */ | ||
| #[Deprecated('use Pdo\Pgsql::getNotify instead', '\Pdo\Pgsql::getNotify(%parametersList%)', since: '8.5')] | ||
| - public function pgsqlGetNotify($fetchMode = PDO::FETCH_DEFAULT, $timeoutMilliseconds = 0) {} | ||
| + public function pgsqlGetNotify($fetchMode = 1, $timeoutMilliseconds = 0) {} |
Contributor
There was a problem hiding this comment.
this PR should have a explanation why this patches is required.
It might also be helpful to have a test for it
Contributor
Author
There was a problem hiding this comment.
This patch exist for a long time and i dunno why.
I just fixed the conflict
Contributor
There was a problem hiding this comment.
ohh I see. what about the second patch file?
Contributor
Author
There was a problem hiding this comment.
Second patch is temporary until JetBrains/phpstorm-stubs#1879 is merged
Contributor
There was a problem hiding this comment.
Second patch is temporary until JetBrains/phpstorm-stubs#1879 is merged
yeah, but that was not clear from this PR. thanks for adjusting the PR description.
LGTM
staabm
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once JetBrains/phpstorm-stubs#1879 is merged we will be able to delete the patch added