Check isFirstClassCallable() before calling getArgs() on nested FuncCall nodes
#5564
+160
−1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| <?php // lint >= 8.1 | ||
|
Contributor
There was a problem hiding this comment. Turn this into a AnalyserIntegrationTest as we are covering crash bugs
Collaborator
Author
There was a problem hiding this comment. Done. Converted the bug-14550 test from an NSRT test ( |
||
|
|
||
| declare(strict_types = 1); | ||
|
|
||
| namespace Bug14550; | ||
|
staabm marked this conversation as resolved.
|
||
|
|
||
| function testArrayKeyFirstAssign(): void | ||
| { | ||
| $fn = array_key_first(...); | ||
| } | ||
|
|
||
| function testArrayKeyLastAssign(): void | ||
| { | ||
| $fn = array_key_last(...); | ||
| } | ||
|
|
||
| function testArrayRandAssign(): void | ||
| { | ||
| $fn = array_rand(...); | ||
| } | ||
|
|
||
| function testCountMinusOneAssign(): void | ||
| { | ||
| $idx = count(...) - 1; | ||
| } | ||
|
|
||
| function testArraySearchInCondition(): void | ||
| { | ||
| if ($key = array_search(...)) { | ||
| } | ||
| } | ||
|
|
||
| function testCountInComparisons(): void | ||
| { | ||
| if (count(...) < 1) {} | ||
| if (0 < count(...)) {} | ||
| } | ||
|
|
||
| function testSizeofInComparisons(): void | ||
| { | ||
| if (sizeof(...) < 1) {} | ||
| if (0 < sizeof(...)) {} | ||
| } | ||
|
|
||
| function testCountMinusOneInComparison(): void | ||
| { | ||
| $i = 0; | ||
| if ($i < count(...) - 1) {} | ||
| } | ||
|
|
||
| function testStrlenInComparisons(): void | ||
| { | ||
| if (strlen(...) < 1) {} | ||
| if (0 < strlen(...)) {} | ||
| } | ||
|
|
||
| function testMbStrlenInComparisons(): void | ||
| { | ||
| if (mb_strlen(...) < 1) {} | ||
| if (0 < mb_strlen(...)) {} | ||
| } | ||
|
|
||
| function testPregMatchInComparisons(): void | ||
| { | ||
| if (preg_match(...) < 1) {} | ||
| if (0 < preg_match(...)) {} | ||
| } | ||
|
|
||
| function testCountIdentical(): void | ||
| { | ||
| if (count(...) === 0) {} | ||
| } | ||
|
|
||
| function testStrlenIdentical(): void | ||
| { | ||
| if (strlen(...) === 0) {} | ||
| if (mb_strlen(...) === 0) {} | ||
| } | ||
|
|
||
| function testArrayKeyFirstNullComparison(): void | ||
| { | ||
| if (array_key_first(...) !== null) {} | ||
| if (array_key_last(...) !== null) {} | ||
| } | ||
|
|
||
| function testGetClassIdentical(): void | ||
| { | ||
| if (get_class(...) === 'stdClass') {} | ||
| if (get_debug_type(...) === 'string') {} | ||
| } | ||
|
|
||
| function testStringFuncIdentical(): void | ||
| { | ||
| if (strtolower(...) === 'test') {} | ||
| } | ||
|
|
||
| function testGettypeEquality(): void | ||
| { | ||
| if (gettype(...) === 'string') {} | ||
| if (gettype(...) == 'string') {} | ||
| } | ||
|
|
||
| function testGetClassEquality(): void | ||
| { | ||
| if (get_class(...) == 'stdClass') {} | ||
| if (get_debug_type(...) == 'string') {} | ||
| } | ||
|
|
||
| function testGetParentClassEquality(): void | ||
| { | ||
| if (get_parent_class(...) === 'stdClass') {} | ||
| } | ||
|
|
||
| function testTrimEquality(): void | ||
| { | ||
| if (trim(...) !== '') {} | ||
| if (ltrim(...) !== '') {} | ||
| if (rtrim(...) !== '') {} | ||
| } | ||
|
|
||
| function testArrayKeysInForeach(): void | ||
| { | ||
| foreach (array_keys(...) as $key) {} | ||
| } | ||
|
|
||
| function testCountInForLoop(): void | ||
| { | ||
| for ($i = 0; $i < count(...); $i++) {} | ||
| for ($i = 0; count(...) > $i; $i++) {} | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.