-
Notifications
You must be signed in to change notification settings - Fork 574
Check isFirstClassCallable() before calling getArgs() on nested FuncCall nodes
#5564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
staabm
merged 8 commits into
phpstan:2.1.x
from
phpstan-bot:create-pull-request/patch-zrmaq32
Apr 29, 2026
+160
−1
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
275d81e
Check `isFirstClassCallable()` before calling `getArgs()` on nested `…
phpstan-bot 9445f33
Add tests for all affected functions in bug-14550 regression test
phpstan-bot 18b34d4
Add isFirstClassCallable() guards in resolveNormalizedIdentical and e…
phpstan-bot 810f7d3
fix tests
staabm ffe4ab4
cleanup
staabm a45a0fd
cleanup
staabm dff735b
Rewrite tests to exercise actual guarded code paths
phpstan-bot ce2e743
Convert bug-14550 test from NSRT to AnalyserIntegrationTest
phpstan-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| <?php // lint >= 8.1 | ||
|
|
||
| declare(strict_types = 1); | ||
|
|
||
| namespace Bug14550; | ||
|
|
||
| use function PHPStan\Testing\assertType; | ||
|
|
||
| // Standalone assignments trigger TypeSpecifier via NodeScopeResolver null-context call | ||
| function testArrayKeyFirstAssign(): void | ||
| { | ||
| $fn = array_key_first(...); | ||
| assertType('Closure(array): (int|string|null)', $fn); | ||
| } | ||
|
|
||
| function testArrayKeyLastAssign(): void | ||
| { | ||
| $fn = array_key_last(...); | ||
| assertType('Closure(array): (int|string|null)', $fn); | ||
| } | ||
|
|
||
| function testArrayRandAssign(): void | ||
| { | ||
| $fn = array_rand(...); | ||
| assertType('(Closure(non-empty-array): (int|string))|(Closure(non-empty-array, int<1, max>): (array<int, int|string>|int|string))', $fn); | ||
| } | ||
|
|
||
| function testCountMinusOneAssign(): void | ||
| { | ||
| $idx = count(...) - 1; | ||
| assertType('Closure(array|Countable, 0|1=): int<0, max>', count(...)); | ||
| } | ||
|
|
||
| // array_search guard needs true context, so it must be in a condition | ||
| function testArraySearchInCondition(): void | ||
| { | ||
| if ($key = array_search(...)) { | ||
| assertType('Closure(mixed, array, bool=): (int|string|false)', $key); | ||
| } | ||
| } | ||
|
|
||
| // Comparison guards in TypeSpecifier (Smaller/SmallerOrEqual) | ||
| function testCountInComparisons(): void | ||
| { | ||
| if (count(...) < 1) {} | ||
| if (0 < count(...)) {} | ||
| assertType('Closure(array|Countable, 0|1=): int<0, max>', count(...)); | ||
| } | ||
|
|
||
| function testSizeofInComparisons(): void | ||
| { | ||
| if (sizeof(...) < 1) {} | ||
| if (0 < sizeof(...)) {} | ||
| assertType('Closure(array|Countable, int=): int', sizeof(...)); | ||
| } | ||
|
|
||
| function testCountMinusOneInComparison(): void | ||
| { | ||
| $i = 0; | ||
| if ($i < count(...) - 1) {} | ||
| assertType('Closure(array|Countable, 0|1=): int<0, max>', count(...)); | ||
| } | ||
|
|
||
| function testStrlenInComparisons(): void | ||
| { | ||
| if (strlen(...) < 1) {} | ||
| if (0 < strlen(...)) {} | ||
| assertType('Closure(string): int<0, max>', strlen(...)); | ||
| } | ||
|
|
||
| function testMbStrlenInComparisons(): void | ||
| { | ||
| if (mb_strlen(...) < 1) {} | ||
| if (0 < mb_strlen(...)) {} | ||
| assertType('Closure(string, string|null=): int<0, max>', mb_strlen(...)); | ||
| } | ||
|
|
||
| function testPregMatchInComparisons(): void | ||
| { | ||
| if (preg_match(...) < 1) {} | ||
| if (0 < preg_match(...)) {} | ||
| assertType('Closure(string, string, array<string>|null=, TFlags=, int=): (0|1|false)', preg_match(...)); | ||
| } | ||
|
|
||
| // Identical/NotIdentical guards in resolveNormalizedIdentical | ||
| function testCountIdentical(): void | ||
| { | ||
| if (count(...) === 0) {} | ||
| assertType('Closure(array|Countable, 0|1=): int<0, max>', count(...)); | ||
| } | ||
|
|
||
| function testStrlenIdentical(): void | ||
| { | ||
| if (strlen(...) === 0) {} | ||
| if (mb_strlen(...) === 0) {} | ||
| assertType('Closure(string): int<0, max>', strlen(...)); | ||
| } | ||
|
|
||
| function testArrayKeyFirstNullComparison(): void | ||
| { | ||
| if (array_key_first(...) !== null) {} | ||
| if (array_key_last(...) !== null) {} | ||
| assertType('Closure(array): (int|string|null)', array_key_first(...)); | ||
| } | ||
|
|
||
| function testGetClassIdentical(): void | ||
| { | ||
| if (get_class(...) === 'stdClass') {} | ||
| if (get_debug_type(...) === 'string') {} | ||
| assertType('Closure(object=): class-string', get_class(...)); | ||
| } | ||
|
|
||
| function testStringFuncIdentical(): void | ||
| { | ||
| if (strtolower(...) === 'test') {} | ||
| assertType('Closure(string): lowercase-string', strtolower(...)); | ||
| } | ||
|
|
||
| // String equality guards in specifyTypesForConstantStringBinaryExpression | ||
| function testGettypeEquality(): void | ||
| { | ||
| if (gettype(...) === 'string') {} | ||
| if (gettype(...) == 'string') {} | ||
| assertType('Closure(mixed): string', gettype(...)); | ||
| } | ||
|
|
||
| function testGetClassEquality(): void | ||
| { | ||
| if (get_class(...) == 'stdClass') {} | ||
| if (get_debug_type(...) == 'string') {} | ||
| assertType('Closure(object=): class-string', get_class(...)); | ||
| } | ||
|
|
||
| function testGetParentClassEquality(): void | ||
| { | ||
| if (get_parent_class(...) === 'stdClass') {} | ||
| assertType('Closure(object|string=): (class-string|false)', get_parent_class(...)); | ||
| } | ||
|
|
||
| function testTrimEquality(): void | ||
| { | ||
| if (trim(...) !== '') {} | ||
| if (ltrim(...) !== '') {} | ||
| if (rtrim(...) !== '') {} | ||
| assertType('Closure(string, string=): string', trim(...)); | ||
| } | ||
|
|
||
| // NodeScopeResolver guards | ||
| function testArrayKeysInForeach(): void | ||
| { | ||
| foreach (array_keys(...) as $key) {} | ||
| assertType('Closure(array, mixed=, bool=): list<int|string>', array_keys(...)); | ||
| } | ||
|
|
||
| function testCountInForLoop(): void | ||
| { | ||
| for ($i = 0; $i < count(...); $i++) {} | ||
| for ($i = 0; count(...) > $i; $i++) {} | ||
| assertType('Closure(array|Countable, 0|1=): int<0, max>', count(...)); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.