Fix counting *scanf() format string placeholders#5594
Open
hakre wants to merge 2 commits intophpstan:2.1.xfrom
Open
Fix counting *scanf() format string placeholders#5594hakre wants to merge 2 commits intophpstan:2.1.xfrom
*scanf() format string placeholders#5594hakre wants to merge 2 commits intophpstan:2.1.xfrom
Conversation
hakre
force-pushed
the
patch-1
branch
4 times, most recently
from
57da830 to
5742f2b
Compare
hakre
changed the title
sscanf/fscanf format string placeholderssscanf/fscanf format string placeholders
Collaborator
|
This pull request has been marked as ready for review. |
staabm
reviewed
May 6, 2026
staabm
reviewed
May 6, 2026
hakre
changed the title
sscanf/fscanf format string placeholders*scanf() format string placeholders
Author
|
Do you know by chance why https://github.com/phpstan/phpstan-src/actions/runs/25431166468/job/74597885107 keeps failing on my changes? I'd like to better understand @staabm |
Contributor
we see the same errors on others PRs targeting 2.1.x -> this means these errors are not related to your PR |
hakre
force-pushed
the
patch-1
branch
5 times, most recently
from
04f1759 to
bd2dc56
Compare
staabm
reviewed
May 7, 2026
| use const PHP_INT_MAX; | ||
| use const PHP_VERSION_ID; | ||
|
|
||
| #[CoversMethod(PrintfHelper::class, 'getScanfPlaceholdersCount')] |
Contributor
There was a problem hiding this comment.
we don't use Covers*/Uses* attributes. please remove them.
Author
There was a problem hiding this comment.
please find the coverage attributes removed.
staabm
reviewed
May 7, 2026
| return new PhpVersion($versionId); | ||
| } | ||
|
|
||
| public static function dataLegacyVersionIds(): Generator |
Contributor
There was a problem hiding this comment.
what is this complicated method doing? couldn't we just have a data-provider which returns a few representative "hard-coded" data-pairs ?
Author
There was a problem hiding this comment.
absolutely – please find it now with just a few hard‑coded IDs.
hakre
force-pushed
the
patch-1
branch
2 times, most recently
from
8a37d48 to
ddd449b
Compare
Additional by-catch fix of a variable misnomer in 023fa08 ("Fix printf parameters rule", 2017-04-02) spotted during review.
Update PrintfHelper.php to make
public function getScanfPlaceholdersCount(string $format): ?int`
return the sscanf() vetted number of placeholders that return/assign
conversions.
Addresses long-standing regressions reported originally in
[phpstan-10260].
References:
- [phpstan-10260]
- phpstan/phpstan#10260 (comment)
- [phpstan-src-5591]
- [phpstan-14567]
- https://3v4l.org/WR85Q
[phpstan-10260]: phpstan/phpstan#10260
[phpstan-src-5591]: phpstan#5591
[phpstan-14567]: phpstan/phpstan#14567
staabm
reviewed
May 8, 2026
Comment on lines
+24
to
+34
| #[RequiresPhp('< 8.0.0')] | ||
| public function testReturnsNullForInvalidPatternOnLegacyPhpVersion(): void | ||
| { | ||
| $this->assertNull($this->printf->getScanfPlaceholdersCount('%a')); | ||
| } | ||
|
|
||
| #[RequiresPhp('>= 8.0.0')] | ||
| public function testReturnsNullForInvalidPatternOnPhp8(): void | ||
| { | ||
| $this->assertNull($this->printf->getScanfPlaceholdersCount('%a')); | ||
| } |
Contributor
There was a problem hiding this comment.
these 2 tests look identical. can't we just merge them and remove the #[RequiresPhp('>= 8.0.0')]?
Comment on lines
+42
to
+54
| if ($this->phpVersion->throwsValueErrorForInternalFunctions()) { | ||
| try { | ||
| $result = sscanf('', '%*n' . $format); | ||
| } catch (ValueError) { | ||
| return null; | ||
| } | ||
| } else { | ||
| $result = @sscanf('', '%*n' . $format); | ||
| } | ||
| if ($result === null) { | ||
| return null; | ||
| } | ||
| return count($result); |
Contributor
There was a problem hiding this comment.
I think this can be simplified
Suggested change
| if ($this->phpVersion->throwsValueErrorForInternalFunctions()) { | |
| try { | |
| $result = sscanf('', '%*n' . $format); | |
| } catch (ValueError) { | |
| return null; | |
| } | |
| } else { | |
| $result = @sscanf('', '%*n' . $format); | |
| } | |
| if ($result === null) { | |
| return null; | |
| } | |
| return count($result); | |
| try { | |
| $result = sscanf('', '%*n' . $format); | |
| } catch (ValueError) { | |
| return null; | |
| } | |
| if ($result === null) { | |
| return null; | |
| } | |
| return count($result); |
which would also simplify the tests IMO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update PrintfHelper.php:
Make
public function getScanfPlaceholdersCount(string $format): ?intreturning the sscanf() vetted number of placeholders that give/return/assign conversions.refs:
sscanf/fscanfformat string at NUL byte before counting placeholders #5591