Replace StubFilesExtensionLoaderTest with ResultCacheNoReflectionTest

Test that BetterReflection is not initialized when ResultCacheManager
constructs the ResultCache, which is the real-world code path that
exercises StubFilesExtensionLoader::getFiles().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: xificurk

phpstan-baseline.neon

@@ -60,6 +60,24 @@ parameters:
 			count: 1
 			path: src/Type/Symfony/InputInterfaceHasOptionDynamicReturnTypeExtension.php
 
+		-
+			message: '#^Accessing PHPStan\\Analyser\\ResultCache\\ResultCacheManagerFactory\:\:class is not covered by backward compatibility promise\. The class might change in a minor PHPStan version\.$#'
+			identifier: phpstanApi.classConstant
+			count: 1
+			path: tests/Analyser/ResultCacheNoReflectionTest.php
+
+		-
+			message: '#^Calling PHPStan\\Analyser\\ResultCache\\ResultCacheManagerFactory\:\:create\(\) is not covered by backward compatibility promise\. The method might change in a minor PHPStan version\.$#'
+			identifier: phpstanApi.method
+			count: 1
+			path: tests/Analyser/ResultCacheNoReflectionTest.php
+
+		-
+			message: '#^Calling PHPStan\\Analyser\\ResultCache\\ResultCacheManager\:\:restore\(\) is not covered by backward compatibility promise\. The method might change in a minor PHPStan version\.$#'
+			identifier: phpstanApi.method
+			count: 1
+			path: tests/Analyser/ResultCacheNoReflectionTest.php
+
 		-
 			message: '#^Accessing PHPStan\\Rules\\Methods\\CallMethodsRule\:\:class is not covered by backward compatibility promise\. The class might change in a minor PHPStan version\.$#'
 			identifier: phpstanApi.classConstant

tests/Analyser/ResultCacheNoReflectionTest.php

@@ -0,0 +1,36 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Analyser;
+
+use LogicException;
+use PHPStan\Analyser\ResultCache\ResultCacheManagerFactory;
+use PHPStan\BetterReflection\Reflector\Reflector;
+use PHPStan\Command\Output;
+use PHPStan\Testing\PHPStanTestCase;
+
+final class ResultCacheNoReflectionTest extends PHPStanTestCase
+{
+
+	public function testRestoreDoesNotUseSourceLocator(): void
+	{
+		$container = self::getContainer();
+
+		$manager = $container->getByType(ResultCacheManagerFactory::class)->create([]);
+		$manager->restore([], true, false, null, $this->createMock(Output::class));
+
+		// Sanity check: verify ThrowingSourceLocator is actually wired up.
+		// If restore() had triggered the source locator, the test would have already failed above.
+		$this->expectException(LogicException::class);
+		$this->expectExceptionMessage('must not be called during result cache construction');
+		$container->getByType(Reflector::class)->reflectClass(self::class);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/../../extension.neon',
+			__DIR__ . '/result-cache-no-reflection-test.neon',
+		];
+	}
+
+}

…/Stubs/Symfony/ThrowingSourceLocator.php tests/Analyser/ThrowingSourceLocator.phptests/Stubs/Symfony/ThrowingSourceLocator.php renamed to tests/Analyser/ThrowingSourceLocator.php tests/Stubs/Symfony/ThrowingSourceLocator.php renamed to tests/Analyser/ThrowingSourceLocator.php

@@ -1,25 +1,25 @@
 <?php declare(strict_types = 1);
 
-namespace PHPStan\Stubs\Symfony;
+namespace PHPStan\Analyser;
 
+use LogicException;
 use PHPStan\BetterReflection\Identifier\Identifier;
 use PHPStan\BetterReflection\Identifier\IdentifierType;
 use PHPStan\BetterReflection\Reflection\Reflection;
 use PHPStan\BetterReflection\Reflector\Reflector;
 use PHPStan\BetterReflection\SourceLocator\Type\SourceLocator;
-use PHPUnit\Framework\Assert;
 
 final class ThrowingSourceLocator implements SourceLocator
 {
 
 	public function locateIdentifier(Reflector $reflector, Identifier $identifier): ?Reflection
 	{
-		Assert::fail('SourceLocator::locateIdentifier must not be called during getFiles()');
+		throw new LogicException('SourceLocator::locateIdentifier must not be called during result cache construction');
 	}
 
 	public function locateIdentifiersByType(Reflector $reflector, IdentifierType $identifierType): array
 	{
-		Assert::fail('SourceLocator::locateIdentifiersByType must not be called during getFiles()');
+		throw new LogicException('SourceLocator::locateIdentifiersByType must not be called during result cache construction');
 	}
 
 }

tests/Stubs/Symfony/stub-loader-test.neon …ser/result-cache-no-reflection-test.neontests/Stubs/Symfony/stub-loader-test.neon renamed to tests/Analyser/result-cache-no-reflection-test.neon tests/Stubs/Symfony/stub-loader-test.neon renamed to tests/Analyser/result-cache-no-reflection-test.neon

@@ -1,5 +1,5 @@
 services:
 	betterReflectionSourceLocator:
 		class: PHPStan\BetterReflection\SourceLocator\Type\SourceLocator
-		factory: PHPStan\Stubs\Symfony\ThrowingSourceLocator
+		factory: PHPStan\Analyser\ThrowingSourceLocator
 		autowired: false