Replace StubFilesExtensionLoaderTest with ResultCacheNoReflectionTest

Test that BetterReflection is not initialized when ResultCacheManager
constructs the ResultCache, which is the real-world code path that
exercises StubFilesExtensionLoader::getFiles().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: xificurk

tests/Analyser/ResultCacheNoReflectionTest.php

@@ -0,0 +1,42 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Analyser;
+
+use PHPStan\Analyser\ResultCache\ResultCacheManagerFactory;
+use PHPStan\BetterReflection\Identifier\Identifier;
+use PHPStan\BetterReflection\Identifier\IdentifierType;
+use PHPStan\BetterReflection\Reflector\Reflector;
+use PHPStan\BetterReflection\SourceLocator\Type\SourceLocator;
+use PHPStan\Command\Output;
+use PHPStan\Testing\PHPStanTestCase;
+use PHPUnit\Framework\AssertionFailedError;
+
+final class ResultCacheNoReflectionTest extends PHPStanTestCase
+{
+
+	public function testRestoreDoesNotUseSourceLocator(): void
+	{
+		$factory = self::getContainer()->getByType(ResultCacheManagerFactory::class);
+		$manager = $factory->create([]);
+		$manager->restore([], true, false, null, $this->createMock(Output::class));
+
+		// Sanity check: verify ThrowingSourceLocator is actually wired up.
+		// If restore() had triggered the source locator, the test would have already failed above.
+		$this->expectException(AssertionFailedError::class);
+		$this->expectExceptionMessage('must not be called during result cache construction');
+		$sourceLocator = self::getContainer()->getByType(SourceLocator::class);
+		$sourceLocator->locateIdentifier(
+			$this->createMock(Reflector::class),
+			new Identifier('stdClass', new IdentifierType()),
+		);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/../../extension.neon',
+			__DIR__ . '/result-cache-no-reflection-test.neon',
+		];
+	}
+
+}

…/Stubs/Symfony/ThrowingSourceLocator.php tests/Analyser/ThrowingSourceLocator.phptests/Stubs/Symfony/ThrowingSourceLocator.php renamed to tests/Analyser/ThrowingSourceLocator.php tests/Stubs/Symfony/ThrowingSourceLocator.php renamed to tests/Analyser/ThrowingSourceLocator.php

@@ -1,6 +1,6 @@
 <?php declare(strict_types = 1);
 
-namespace PHPStan\Stubs\Symfony;
+namespace PHPStan\Analyser;
 
 use PHPStan\BetterReflection\Identifier\Identifier;
 use PHPStan\BetterReflection\Identifier\IdentifierType;
@@ -14,12 +14,12 @@ final class ThrowingSourceLocator implements SourceLocator
 
 	public function locateIdentifier(Reflector $reflector, Identifier $identifier): ?Reflection
 	{
-		Assert::fail('SourceLocator::locateIdentifier must not be called during getFiles()');
+		Assert::fail('SourceLocator::locateIdentifier must not be called during result cache construction');
 	}
 
 	public function locateIdentifiersByType(Reflector $reflector, IdentifierType $identifierType): array
 	{
-		Assert::fail('SourceLocator::locateIdentifiersByType must not be called during getFiles()');
+		Assert::fail('SourceLocator::locateIdentifiersByType must not be called during result cache construction');
 	}
 
 }

tests/Stubs/Symfony/stub-loader-test.neon …ser/result-cache-no-reflection-test.neontests/Stubs/Symfony/stub-loader-test.neon renamed to tests/Analyser/result-cache-no-reflection-test.neon tests/Stubs/Symfony/stub-loader-test.neon renamed to tests/Analyser/result-cache-no-reflection-test.neon

@@ -1,5 +1,5 @@
 services:
 	betterReflectionSourceLocator:
 		class: PHPStan\BetterReflection\SourceLocator\Type\SourceLocator
-		factory: PHPStan\Stubs\Symfony\ThrowingSourceLocator
+		factory: PHPStan\Analyser\ThrowingSourceLocator
 		autowired: false