Array shape is oversimplified when defined with a variable key

[VincentLanglet]

Bug report

When an array key is 'foo'|'bar' the array shape is too much simplified

Code snippet that reproduces the problem

https://phpstan.org/r/42797189-cf51-44e5-a0f7-fef18ce9545a

Expected output

Best would be

array{id: null, bar: string}|array{id: null, foo: string}

but I would expect at least

array{id: null, bar?: string, foo?: string}

Is something something possible without impacting (too much ?) the performance ?

Did PHPStan help you today? Did it make you happy in any way?

Sure, I'm adding phpdoc for arrays and it detects so much

[nusphere]

I recognized a similar problem.

https://phpstan.org/r/32f37b9f-fdd9-472b-a040-9218f14b62e5

the optimal return value is:

array{street?: array{change_to: string}, city?: array{change_to: string}, variation_count?: int<1, max>}

or

array<'city'|'street', array{change_to: string}>&array{variation_count?: int<1, max>}

I know that this is basically an array combination. But unfortunately I can't find a "good" option. Unfortunately, the proposed solution for my example feels wrong, because variation_count will not contain any change information.

array<'city'|'street'|'variation_count', array{change_to: string}|int<1, max>>.

Unfortunately that feels wrong.

[nusphere]

also i tried to use own phpstan-type to combine them as intersections, but this also fails

https://phpstan.org/r/d0127c2e-8c01-4738-9f3f-54c29220349c

[phpstan-bot]

@nusphere After the latest push in 1.11.x, PHPStan now reports different result with your code snippet:

@@ @@
-21: PHPDoc tag @return contains unresolvable type.
+36: Method Demo::diffAddresses() should return array{city?: array{change_to: string}, street?: array{change_to: string}} but returns array<'city'|'street'|'variation_count', array{change_to: string}|int<1, max>>.

Full report

Line	Error
36	`Method Demo::diffAddresses() should return array{city?: array{change_to: string}, street?: array{change_to: string}} but returns array<'city'

[nusphere]

The new error appears to resolve the phpstan type, unfortunately not yet as an intersection.

In my case at least it doesn't work without a clean intersection. but I don't know whether phpstan can process this internally, since I think it works with type elimination.

Maybe one of the developers can say something about it.

[phpstan-bot]

Closed via merging phpstan/phpstan-src#5193