Merge pull request #105 from phug-php/fix/strict-in-array

Use strict in_array checks in the lexer

split: 594ea1a79de8078e9e5c0edc1440db2b574b23d0

Author: kylekatarnls

Lexer/Partial/IndentStyleTrait.php

@@ -42,7 +42,7 @@ public function getIndentStyle()
      */
     public function setIndentStyle($indentStyle)
     {
-        if (!in_array($indentStyle, [null, Lexer::INDENT_TAB, Lexer::INDENT_SPACE])) {
+        if (!in_array($indentStyle, [null, Lexer::INDENT_TAB, Lexer::INDENT_SPACE], true)) {
             throw new \InvalidArgumentException(
                 'indentStyle needs to be null or one of the INDENT_* constants of the lexer'
             );

Lexer/Scanner/ConditionalScanner.php

@@ -26,7 +26,7 @@ public function scan(State $state)
                 //Make sure spaces are replaced from `elseif`/`else if` to make a final keyword, "elseif"
                 $token->setName(preg_replace('/[ \t]/', '', $token->getName()));
 
-                if ($token->getName() === 'else' && !in_array($token->getSubject(), ['', false, null])) {
+                if ($token->getName() === 'else' && !in_array($token->getSubject(), ['', false, null], true)) {
                     $state->throwException(
                         'The `else`-conditional statement can\'t have a subject'
                     );

Lexer/Scanner/KeywordScanner.php

@@ -24,7 +24,7 @@ public function scan(State $state)
             )) {
                 $name = $reader->getMatch('name');
 
-                if (in_array($name, $keywords)) {
+                if (in_array($name, $keywords, true)) {
                     $value = $reader->getMatch('value');
                     if (mb_substr($value, 0, 1) === ' ') {
                         $value = mb_substr($value, 1);

Lexer/Scanner/TextScanner.php

@@ -19,7 +19,7 @@ class TextScanner implements ScannerInterface
 
     private function isTextStartToTrim(State $state, $text)
     {
-        return in_array(mb_substr((string) $text, 0, 1), [' ', "\t"]) && !$state->isAfterInterpolation();
+        return in_array(mb_substr((string) $text, 0, 1), [' ', "\t"], true) && !$state->isAfterInterpolation();
     }
 
     private function leftTrimValueIfNotAfterInterpolation(State $state, TextToken $token)