Add exception for scandir failures

Author: kylekatarnls

src/Phug/Split/Command/Analyze.php

@@ -3,6 +3,7 @@
 namespace Phug\Split\Command;
 
 use Phug\Split;
+use Phug\Split\UnableToListDirectoryItems;
 use SimpleCli\SimpleCli;
 use Traversable;
 
@@ -106,8 +107,13 @@ protected function dumpPackagesTree(Split $cli, iterable $packages, int $level =
 
     protected function mapDirectories(string $directory, callable $callback): iterable
     {
-        /** @psalm-suppress RiskyTruthyFalsyComparison */
-        foreach ((scandir($directory) ?: []) as $element) {
+        $elements = scandir($directory);
+
+        if ($elements === false) {
+            throw new UnableToListDirectoryItems($directory);
+        }
+
+        foreach ($elements as $element) {
             if (substr($element, 0, 1) === '.') {
                 continue;
             }

src/Phug/Split/Command/CommandBase.php

@@ -51,6 +51,8 @@ protected function gitEscape(string $value): string
      * @param array       $options  CLI git command options
      * @param string|null $redirect redirection suffix (like '2>&1')
      *
+     * @psalm-param truthy-string|null $redirect
+     *
      * @return string
      *
      * @psalm-suppress UndefinedThisPropertyFetch
@@ -61,7 +63,6 @@ protected function getGitCommand(string $command, array $options = [], ?string $
             $command .= ' --'.$name.'='.$this->gitEscape($value);
         }
 
-        /** @psalm-suppress RiskyTruthyFalsyComparison */
         return $this->gitProgram.' '.$command.($redirect ? ' '.$redirect : '');
     }
 
@@ -72,6 +73,8 @@ protected function getGitCommand(string $command, array $options = [], ?string $
      * @param array       $options  CLI git command options
      * @param string|null $redirect redirection suffix (like '2>&1')
      *
+     * @psalm-param truthy-string|null $redirect
+     *
      * @return string
      */
     protected function git(string $command, array $options = [], ?string $redirect = null): string

src/Phug/Split/UnableToListDirectoryItems.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Phug\Split;
+
+use RuntimeException;
+use Throwable;
+
+class UnableToListDirectoryItems extends RuntimeException
+{
+    public function __construct(string $directory, int $code = 0, ?Throwable $previous = null)
+    {
+        parent::__construct("Unable to list items of the directory '$directory'", $code, $previous);
+    }
+}