Fix DeleteAsyncOperation flag always defaulting to true when false in database#131
Closed
Copilot wants to merge 2 commits into
Closed
Fix DeleteAsyncOperation flag always defaulting to true when false in database#131Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: phuocle <479729+phuocle@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix to check and add DeleteAsyncOperation flag
Fix DeleteAsyncOperation flag always defaulting to true when false in database
Dec 18, 2025
Owner
|
@copilot continue improve check if class is plugin type custom action, custom api ? Is it add like plugin or workflow. You need double check TaskServer.cs for a lot of deployment task for: plugin, workflow, custom action, custom api, data provider to understand the idea that you can add CrmPluginRegistration attribute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CommandAddCrmPluginRegistrationcommand only addedDeleteAsyncOperation = truewhen the database value was true, but omitted it when false. SinceCrmPluginRegistrationAttribute.DeleteAsyncOperationdefaults totrue, plugins withasyncautodelete = falsein the database incorrectly gotDeleteAsyncOperation = truein generated code.Changes
DeleteAsyncOperationwith explicit boolean value from databaseasyncautodeleteto variable for clarityThis aligns with how
TaskServer.cshandles the flag (line 1440) and ensures generated plugin registration attributes accurately reflect CRM configuration.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.