Fix -Wtautological-constant-out-of-range-compare in serializer (nlohmann#5050)

cacharle · web-flow · commit 5ed07097faa6 · 2026-01-13T17:19:38.000+01:00
Signed-off-by: Charles Cabergs &lt;me@cacharle.xyz&gt;
diff --git a/include/nlohmann/detail/output/serializer.hpp b/include/nlohmann/detail/output/serializer.hpp
@@ -919,7 +919,7 @@ class serializer
             }
         };
 
-        JSON_ASSERT(byte < utf8d.size());
+        JSON_ASSERT(static_cast<std::size_t>(byte) < utf8d.size());
         const std::uint8_t type = utf8d[byte];
 
         codep = (state != UTF8_ACCEPT)
diff --git a/single_include/nlohmann/json.hpp b/single_include/nlohmann/json.hpp
@@ -19755,7 +19755,7 @@ class serializer
             }
         };
 
-        JSON_ASSERT(byte < utf8d.size());
+        JSON_ASSERT(static_cast<std::size_t>(byte) < utf8d.size());
         const std::uint8_t type = utf8d[byte];
 
         codep = (state != UTF8_ACCEPT)

Original file line number	Diff line number	Diff line change
`@@ -919,7 +919,7 @@ class serializer`
`919`	`919`	`}`
`920`	`920`	`};`
`921`	`921`
`922`		`- JSON_ASSERT(byte < utf8d.size());`
	`922`	`+ JSON_ASSERT(static_cast<std::size_t>(byte) < utf8d.size());`
`923`	`923`	`const std::uint8_t type = utf8d[byte];`
`924`	`924`
`925`	`925`	`codep = (state != UTF8_ACCEPT)`
Original file line number	Diff line number	Diff line change
`@@ -19755,7 +19755,7 @@ class serializer`
`19755`	`19755`	`}`
`19756`	`19756`	`};`
`19757`	`19757`
`19758`		`- JSON_ASSERT(byte < utf8d.size());`
	`19758`	`+ JSON_ASSERT(static_cast<std::size_t>(byte) < utf8d.size());`
`19759`	`19759`	`const std::uint8_t type = utf8d[byte];`
`19760`	`19760`
`19761`	`19761`	`codep = (state != UTF8_ACCEPT)`