Fix avoid imagedestroy on PHP 8+#224
Merged
casperbakker merged 2 commits intopicqer:mainfrom Jan 8, 2026
Merged
Conversation
Member
|
Thanks. But as we only support after PHP 8.2, the call can be removed completely. No need to do the version check. Can you update that? |
Contributor
Author
|
Hello @casperbakker! Good point, thanks. I’ve removed the imagedestroy() calls completely. 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes all imagedestroy() calls from the GD image generation logic.
Since the project only supports PHP ≥ 8.2, GD images are objects and calling imagedestroy() has no effect and is deprecated.
Changes included
imagedestroy()callsMotivation
imagedestroy()has been deprecated since PHP 8.5 and has no effect since PHP 8.0. Removing it aligns the codebase with the supported PHP versions and avoids deprecation warnings while keeping the code clean and forward-compatible.Detected deprecation messages: