Merge pull request #24 from pie-framework/fix/PIE-447-wip

fix: wire npm auth correctly in release workflow; exclude math-inline…

Author: CarlaCostea

.changeset/config.json

@@ -7,5 +7,5 @@
   "access": "public",
   "baseBranch": "master",
   "updateInternalDependencies": "patch",
-  "ignore": ["esm-player-test"]
+  "ignore": ["esm-player-test", "@pie-element/math-inline", "@pie-element/math-templated"]
 }

.github/workflows/release.yml

@@ -90,6 +90,7 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 20.x
+          registry-url: 'https://registry.npmjs.org'
 
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
@@ -319,8 +320,8 @@ jobs:
           commit: 'chore(release): version packages'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          NPM_TOKEN: ${{ env.PUBLISH_NPM_TOKEN }}
-          NODE_AUTH_TOKEN: ${{ env.PUBLISH_NODE_AUTH_TOKEN }}
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NPM_CONFIG_REGISTRY: https://registry.npmjs.org/
           RELEASE_CHANNEL: ${{ steps.release_channel.outputs.channel }}
 

scripts/changeset-publish-resolved-workspaces.mjs

@@ -563,7 +563,16 @@ const collectRuntimeWorkspaceDependencyClosure = (targetPackages) => {
         });
       }
 
-      stack.push(dependency.dependencyName);
+      // Only recurse into a workspace dep if it is also being published in this
+      // run. If it is already on npm at the correct version, its published
+      // manifest has already-resolved (non-workspace) deps — there is no need
+      // to walk its local workspace package.json, and doing so would
+      // incorrectly flag transitive workspace:* refs that are irrelevant to
+      // the consumer (e.g. @pie-lib/render-ui@6.1.0 on npm having a local
+      // workspace:* on @pie-lib/math-rendering which hasn't been republished).
+      if (targetPackages.has(dependency.dependencyName)) {
+        stack.push(dependency.dependencyName);
+      }
     }
   }