Parity of rendering for McPopulatedBlank#18
Merged
Conversation
…sibility (CONTOOL-2194) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…sts (CONTOOL-2194) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…font investigation (CONTOOL-2194) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- grill-me SKILL.md: take master's expanded version - improve-codebase-architecture SKILL.md: keep branch version (LANGUAGE.md vocabulary) - mc-populated-blank-visual-parity.spec.ts: keep branch version (superset with live parity section) - package.json: both sets of scripts preserved (test:e2e:mcpb + test:a11y*) - bun.lock: keep branch version (turbo@2.8.10 from Renaissance registry) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…pec from McPopulatedBlank (CONTOOL-2194) Extracts four pure functions (computeFeatureAudioSkin, computeDisplayChoiceId, computeResultText, computeLegendText) into computeDisplayState.ts with 25 unit tests. Replaces the 40-line hand-written CSS var array in computeLayoutStyle.ts with a data-driven CSS_VAR_SPEC record, making LayoutLimits-to-CSS-var mapping type-safe and exhaustive-checked at compile time. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…test (CONTOOL-2194)
…test (CONTOOL-2194)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a lot of tests to show that McPopulatedBlank behaves the same as the Learnosity CQT's. I also used some refactoring tools to improve the code quality and testability. I am ready for others to give me feedback.