fix(passage): code review improvements PD-4040

Author: arimieandreea

packages/passage/configure/src/__tests__/main.test.js

@@ -1,6 +1,6 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { Main } from '../design'; // Adjust path if needed
+import { Main } from '../design';
 
 jest.mock('@pie-lib/pie-toolbox/config-ui', () => ({
   layout: {

packages/passage/configure/src/__tests__/passage.test.js

@@ -1,6 +1,6 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { PassageComponent } from '../passage'; // adjust the import path as needed
+import { PassageComponent } from '../passage';
 import { InputContainer } from '@pie-lib/pie-toolbox/config-ui';
 import defaults from '../defaults';
 

packages/passage/configure/src/common.jsx

@@ -10,7 +10,7 @@ import DialogContent from '@material-ui/core/DialogContent';
 import DialogContentText from '@material-ui/core/DialogContentText';
 import DialogActions from '@material-ui/core/DialogActions';
 
-function RemoveAddButton({ classes, label, type = 'add', onClick }) {
+export const RemoveAddButton = ({ classes, label, type = 'add', onClick }) => {
   const Tag = type === 'add' ? AddCircleIcon : RemoveCircleIcon;
   return (
     <Button color="primary" size="small" className={classes.root} onClick={onClick}>
@@ -61,11 +61,11 @@ export const ConfimationDialog = ({ content, cancel, title, ok, open, onOk, onCa
 );
 
 ConfimationDialog.propTypes = {
-  content: PropTypes.string,
-  title: PropTypes.string,
-  cancel: PropTypes.string,
-  ok: PropTypes.string,
-  open: PropTypes.bool,
-  onCancel: PropTypes.func,
-  onOk: PropTypes.func,
+  content: PropTypes.string.isRequired,
+  title: PropTypes.string.isRequired,
+  cancel: PropTypes.string.isRequired,
+  ok: PropTypes.string.isRequired,
+  open: PropTypes.bool.isRequired,
+  onCancel: PropTypes.func.isRequired,
+  onOk: PropTypes.func.isRequired,
 };

packages/passage/configure/src/design.jsx

@@ -132,8 +132,7 @@ export class Main extends React.Component {
           />
         }
       >
-        {passages.map((passage, passageIndex) => {
-          return (
+        {passages.map((passage, passageIndex) =>
             <React.Fragment key={passageIndex}>
               {passageIndex > 0 && (
                 <Typography variant="h5" className={classes.additionalPassageHeading}>
@@ -159,8 +158,7 @@ export class Main extends React.Component {
                 <PassageButton label={`Add ${additionalPassage.label}`} onClick={this.addAdditionalPassage} />
               )}
             </React.Fragment>
-          );
-        })}
+          )}
         <ConfimationDialog
           open={showConfirmationDialog}
           title={'Warning'}

packages/passage/configure/src/passage.jsx

@@ -71,12 +71,7 @@ export class PassageComponent extends React.Component {
     const defaultImageMaxWidth = maxImageWidth && maxImageWidth.prompt;
     const defaultImageMaxHeight = maxImageHeight && maxImageHeight.prompt;
 
-    const getPluginProps = (customConfiguration) => {
-      return {
-        ...baseInputConfiguration,
-        ...customConfiguration,
-      };
-    };
+    const getPluginProps = (customConfiguration) => ({...baseInputConfiguration,...customConfiguration});
 
     return (
       <React.Fragment>