Skip to content

Commit 500ea42

Browse files
fix(stimulus-tabs): simplify baseHeadingLevel checks in renderTab method
1 parent d5c95b5 commit 500ea42

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

packages/passage/src/stimulus-tabs.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,9 +173,9 @@ class StimulusTabs extends React.Component {
173173

174174
renderTab(tab, disabledTabs) {
175175
const { baseHeadingLevel } = this.props;
176-
const clampedLevel = !!baseHeadingLevel ? Math.min(6, Math.max(1, baseHeadingLevel)) : undefined;
177-
const TitleTag = !!baseHeadingLevel ? `h${clampedLevel}` : 'h2'; // default to h2 if no base level is provided - this was the previous behavior
178-
const textLevel = !!baseHeadingLevel ? Math.min(6, Math.max(1, clampedLevel + 1)) : undefined; // promote text headings one level above title
176+
const clampedLevel = baseHeadingLevel ? Math.min(6, Math.max(1, baseHeadingLevel)) : undefined;
177+
const TitleTag = baseHeadingLevel ? `h${clampedLevel}` : 'h2'; // default to h2 if no base level is provided - this was the previous behavior
178+
const textLevel = baseHeadingLevel ? Math.min(6, Math.max(1, clampedLevel + 1)) : undefined; // promote text headings one level above title
179179

180180
return (
181181
<Passage key={tab.id} id={`tabpanel-${tab.id}`} role="tabpanel" aria-labelledby={`button-${tab.id}`}>
@@ -203,7 +203,7 @@ class StimulusTabs extends React.Component {
203203

204204
{tab.text && (
205205
<Purpose purpose="passage-text">
206-
<div key={tab.id} className="text" dangerouslySetInnerHTML={{ __html: !!baseHeadingLevel ? transformDataHeadings(tab.text, textLevel) : tab.text }} />
206+
<div key={tab.id} className="text" dangerouslySetInnerHTML={{ __html: baseHeadingLevel ? transformDataHeadings(tab.text, textLevel) : tab.text }} />
207207
</Purpose>
208208
)}
209209
</Passage>

0 commit comments

Comments
 (0)