Skip to content

fix(number-line): adjust number input container PIE-134 #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlaCostea merged 1 commit into from
Apr 23, 2026
Merged

fix(number-line): adjust number input container PIE-134 #2996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/number-line/configure/src/domain.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { MiniField } from './number-text-field';
import NumberTextField from './number-text-field';
import PropTypes from 'prop-types';
import React from 'react';
import { styled } from '@mui/material/styles';
Expand All @@ -15,6 +15,10 @@ const FlexRow = styled('div')({
display: 'flex',
alignItems: 'center',
gap: '10px',

'.MuiInputBase-input': {
padding: '16.5px 14px !important',
},
});

const sort = (domain) => {
Expand Down Expand Up @@ -51,11 +55,11 @@ export class Domain extends React.Component {
<DisplayFlex>
<FlexRow>
<label>Min Value</label>
<MiniField min={-100000} max={99999} value={domain.min} name={DOMAIN_BEGIN} onChange={this.changeMin} />
<NumberTextField min={-100000} max={99999} value={domain.min} name={DOMAIN_BEGIN} onChange={this.changeMin} />
</FlexRow>
<FlexRow>
<label>Max Value</label>
<MiniField min={-99999} max={100000} value={domain.max} name={DOMAIN_END} onChange={this.changeMax} />
<NumberTextField min={-99999} max={100000} value={domain.max} name={DOMAIN_END} onChange={this.changeMax} />
</FlexRow>
</DisplayFlex>
);
Expand Down
12 changes: 7 additions & 5 deletions packages/number-line/configure/src/main.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ let majorValues = {};

const StyledNumberTextField = styled(NumberTextField)({
width: '150px',
});


'.MuiInputBase-input': {
padding: '16.5px 14px',
},
});

const Row = styled('div')(({ theme }) => ({
display: 'flex',
Expand Down Expand Up @@ -258,9 +260,9 @@ export class Main extends React.Component {
ticks.minor < 1
? math.number(math.ceil(minorLimits.min))
: ticks.minor >= math.number(math.ceil(minorLimits.min)) &&
ticks.minor <= math.number(math.floor(minorLimits.max))
? ticks.minor
: math.number(math.ceil(minorLimits.min));
ticks.minor <= math.number(math.floor(minorLimits.max))
? ticks.minor
: math.number(math.ceil(minorLimits.min));
ticks.integerTick = ticks.minor;
minorValues = { decimal: [], fraction: [] };
ticks.fractionTick = '0';
Expand Down
Loading