Skip to content

fix(hotspot): avoid setting hovercolor in view and eval mode PIE-435 #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlaCostea merged 1 commit into from
May 7, 2026
Merged

fix(hotspot): avoid setting hovercolor in view and eval mode PIE-435 #3012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions packages/hotspot/src/hotspot/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,21 +94,16 @@ class HotspotComponent extends React.Component {
} = this.props;
const { showCorrect } = this.state;
const isEvaluateMode = mode === 'evaluate';
const isGatherMode = mode === 'gather';
const showCorrectAnswerToggle = isEvaluateMode && !responseCorrect;
const showRationale = rationale && (hasText(rationale) || hasMedia(rationale));
const showTeacherInstructions =
teacherInstructions && (hasText(teacherInstructions) || hasMedia(teacherInstructions));

return (
<StyledUiLayout
extraCSSRules={extraCSSRules}
id={'main-container'}
fontSizeFactor={fontSizeFactor}
>
<StyledUiLayout extraCSSRules={extraCSSRules} id={'main-container'} fontSizeFactor={fontSizeFactor}>
{showTeacherInstructions && (
<StyledCollapsible
labels={{ hidden: 'Show Teacher Instructions', visible: 'Hide Teacher Instructions' }}
>
<StyledCollapsible labels={{ hidden: 'Show Teacher Instructions', visible: 'Hide Teacher Instructions' }}>
<PreviewPrompt className="prompt" prompt={teacherInstructions} />
</StyledCollapsible>
)}
Expand Down Expand Up @@ -138,7 +133,7 @@ class HotspotComponent extends React.Component {
dimensions={dimensions}
imageUrl={imageUrl}
hotspotColor={hotspotColor}
hoverOutlineColor={hoverOutlineColor}
hoverOutlineColor={isGatherMode ? hoverOutlineColor : undefined}
selectedHotspotColor={selectedHotspotColor}
multipleCorrect={multipleCorrect}
outlineColor={outlineColor}
Expand Down
Loading