Merge pull request #2269 from pie-framework/develop

fix: PIE-674, PIE-662, PIE-705, PIE-674, PIE-963

Author: CarlaCostea

.github/workflows/ci.yml

@@ -5,6 +5,12 @@ on:
     branches: [develop, master]
   pull_request:
     branches: [develop, master]
+  workflow_dispatch:
+    inputs:
+      ref:
+        description: Branch or commit to publish missing packages from
+        required: false
+        default: master
 
 jobs:
   test:
@@ -76,3 +82,37 @@ jobs:
       - run: yarn install
       - run: scripts/release --build
       - run: scripts/release --release --loglevel verbose
+
+  # Manually-triggered retry: publishes only package versions that are missing
+  # from the registry (lerna publish from-package), skipping already-published
+  # ones. Use this to finish a release where some packages failed to publish
+  # (e.g. a transient npm provenance/transparency-log error) without re-running
+  # `lerna version`.
+  publish-missing:
+    needs: test
+    if: github.event_name == 'workflow_dispatch'
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      id-token: write   # REQUIRED for npm trusted publishing
+    steps:
+      - uses: actions/checkout@v5
+        with:
+          ref: ${{ github.event.inputs.ref }}
+          fetch-depth: 0
+      - name: Configure Git
+        run: |
+          git config user.name "github-actions[bot]"
+          git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
+      - uses: actions/setup-node@v5
+        with:
+          node-version: 24
+          registry-url: https://registry.npmjs.org/
+          cache: yarn
+      - run: yarn install
+      - run: scripts/release --build
+      # Invoke lerna directly (not via scripts/release) so this step does not
+      # depend on the scripts/release version present on the checked-out ref.
+      # `from-package` publishes only versions missing from the registry and
+      # never versions or pushes tags, so it needs no write access to the repo.
+      - run: npx lerna publish from-package --yes --loglevel verbose

packages/editable-html-tip-tap/src/components/MenuBar.jsx

@@ -480,6 +480,11 @@ const StyledMenuBarRoot = styled('div')(({ theme }) => ({
     background: 'none',
     border: 'none',
     cursor: 'pointer',
+    // previously we had implicit 24×24 icon rendering for mui svg icons, but now we need to explicitly set the size to 24×24 to match the previous behavior
+    '& svg': {
+      width: '24px',
+      height: '24px',
+    },
     '&:hover': {
       color: 'black',
     },

packages/editable-html-tip-tap/src/components/TiptapContainer.jsx

@@ -168,6 +168,7 @@ function TiptapContainer(props) {
 
       el.style.visibility = 'hidden';
       el.style.position = 'absolute';
+      el.style.whiteSpace = 'nowrap';
       el.textContent = 'W'.repeat(props.charactersLimit);
 
       rootRef.current.appendChild(el);

packages/editable-html-tip-tap/src/components/__tests__/InlineDropdown.test.jsx

@@ -185,6 +185,85 @@ describe('InlineDropdown', () => {
     });
   });
 
+  it('uses the current node when closing on outside click after the node prop changes', async () => {
+    const onToolbarCloseRequest = jest.fn((_tuple, _editor, onConfirm) => onConfirm());
+    const options = {
+      ...mockOptions,
+      onToolbarCloseRequest,
+    };
+    const updatedNode = {
+      attrs: { index: '1', value: 'Updated Option', error: false },
+      nodeSize: 1,
+    };
+
+    const { queryByTestId, rerender } = render(<InlineDropdown {...defaultProps} options={options} selected={true} />);
+
+    await waitFor(() => {
+      expect(queryByTestId('inline-dropdown-toolbar')).toBeInTheDocument();
+    });
+
+    rerender(<InlineDropdown {...defaultProps} options={options} node={updatedNode} selected={true} />);
+
+    fireEvent.mouseDown(document.body);
+
+    await waitFor(() => {
+      expect(onToolbarCloseRequest).toHaveBeenCalledWith(
+        [updatedNode, 5],
+        expect.anything(),
+        expect.any(Function),
+        expect.any(Function),
+      );
+    });
+  });
+
+  it('respects hold state for the current node after the node prop changes', async () => {
+    const updatedNode = {
+      attrs: { index: '1', value: 'Updated Option', error: false },
+      nodeSize: 1,
+    };
+
+    mockEditor._holdInlineDropdownToolbarIndex = '1';
+
+    const { queryByTestId, rerender } = render(<InlineDropdown {...defaultProps} selected={true} />);
+
+    await waitFor(() => {
+      expect(queryByTestId('inline-dropdown-toolbar')).toBeInTheDocument();
+    });
+
+    rerender(<InlineDropdown {...defaultProps} node={updatedNode} selected={true} />);
+
+    fireEvent.mouseDown(document.body);
+
+    await waitFor(() => {
+      expect(queryByTestId('inline-dropdown-toolbar')).toBeInTheDocument();
+    });
+  });
+
+  it('rebinds the outside-click listener when the node prop changes while the toolbar is open', async () => {
+    const addSpy = jest.spyOn(document, 'addEventListener');
+    const removeSpy = jest.spyOn(document, 'removeEventListener');
+    const updatedNode = { ...mockNode, attrs: { ...mockNode.attrs, value: 'Updated Option' } };
+
+    const { rerender } = render(<InlineDropdown {...defaultProps} selected={true} />);
+
+    await waitFor(() => {
+      expect(addSpy).toHaveBeenCalledWith('mousedown', expect.any(Function));
+    });
+
+    const removeCallsBeforeRerender = removeSpy.mock.calls.filter(([type]) => type === 'mousedown').length;
+
+    rerender(<InlineDropdown {...defaultProps} node={updatedNode} selected={true} />);
+
+    await waitFor(() => {
+      const removeCallsAfterRerender = removeSpy.mock.calls.filter(([type]) => type === 'mousedown').length;
+      expect(removeCallsAfterRerender).toBeGreaterThan(removeCallsBeforeRerender);
+      expect(addSpy).toHaveBeenCalledWith('mousedown', expect.any(Function));
+    });
+
+    addSpy.mockRestore();
+    removeSpy.mockRestore();
+  });
+
   it('has correct border styling', () => {
     const { container } = render(<InlineDropdown {...defaultProps} />);
     const dropdownDiv = container.querySelector('div[style*="border"]');

packages/editable-html-tip-tap/src/components/respArea/InlineDropdown.jsx

@@ -126,7 +126,7 @@ const InlineDropdown = (props) => {
     }
 
     return () => document.removeEventListener('mousedown', handleClickOutside);
-  }, [showToolbar]);
+  }, [showToolbar, node]);
 
   return (
     <NodeViewWrapper

packages/mask-markup/src/choices/choice.jsx

@@ -71,8 +71,8 @@ export default function Choice({ choice, disabled, instanceId }) {
       style={
         isDragging
           ? {
-              width: rootRef.current?.offsetWidth,
-              height: rootRef.current?.offsetHeight,
+               width: rootRef.current?.offsetWidth || 90, // min-width of chip is 90px, so if we don't have the width, we can use 90px as a fallback
+               height: rootRef.current?.offsetHeight || 32, // min-height of chip is 32px, so if we don't have the height, we can use 32px as a fallback
             }
           : {}
       }

scripts/release

@@ -26,9 +26,9 @@ const CWD = process.cwd();
  *   - `next`: Defaults to `false`.
  */
 const argv = minimist(process.argv.slice(2), {
-  boolean: ['dry-run', 'next', 'build', 'test', 'release'],
+  boolean: ['dry-run', 'next', 'build', 'test', 'release', 'publish'],
   string: ['loglevel'],
-  default: { 'dry-run': false, next: false, build: false, test: false, release: false },
+  default: { 'dry-run': false, next: false, build: false, test: false, release: false, publish: false },
 });
 
 /**
@@ -179,6 +179,26 @@ const release = () => {
   runCmd(`git push origin ${getCurrentBranch()} --follow-tags`);
 };
 
+/**
+ * Publishes any package versions that are missing from the registry, without
+ * versioning or creating tags.
+ *
+ * Uses `lerna publish from-package`, which inspects each package's current
+ * version and publishes only those not already present on npm. This makes it
+ * a safe, idempotent retry for a release where some packages published and
+ * others failed (e.g. a transient provenance/transparency-log error): already
+ * published packages are skipped and only the missing ones are published.
+ *
+ * Intended to be run from a branch/commit that already carries the intended
+ * versions (typically `master` after a `lerna version` has run).
+ */
+const publishMissing = () => {
+  log(chalk.magenta('--- PUBLISH MISSING PACKAGES (from-package) ---'));
+  let releaseCmd = 'npx lerna publish from-package --yes';
+  if (argv.loglevel) releaseCmd += ` --loglevel ${argv.loglevel}`;
+  runCmd(releaseCmd);
+};
+
 /**
  * Executes the build and release process.
  *
@@ -193,7 +213,7 @@ const release = () => {
 const run = () => {
   try {
     // If no specific flags, run full workflow
-    const anyFlag = argv.build || argv.test || argv.release;
+    const anyFlag = argv.build || argv.test || argv.release || argv.publish;
     if (!anyFlag) {
       build();
       test();
@@ -202,6 +222,7 @@ const run = () => {
       if (argv.build) build();
       if (argv.test) test();
       if (argv.release) release();
+      if (argv.publish) publishMissing();
     }
     log(chalk.green('✅ Tasks completed successfully.'));
   } catch (err) {