Skip to content

fix(charting): avoid floating-point precision errors in the % operator PIE-434 #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreeimiron wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(charting): avoid floating-point precision errors in the % operator PIE-434 #2222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions packages/charting/src/grid.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,22 @@ export class Grid extends React.Component {
const { scale = {}, size = {}, range = {} } = graphProps || {};
const { step = 0, labelStep = 0 } = range;
const highlightNonLabel = step && labelStep && step < labelStep;
// if highlightNonLabel is true, we need to separate the unlabled lines in order to render them in a different color

// Avoid floating-point precision errors in the % operator.
// e.g. 0.6 % 0.2 = 0.19999999999999996, but safeModulo(0.6, 0.2) = 0
const safeModulo = (value, step) => {
const valueDecimals = (value.toString().split('.')[1] || '').length;
const stepDecimals =(step.toString().split('.')[1] || '').length
const decimals = Math.max(valueDecimals, stepDecimals);
const factor = Math.pow(10, decimals);

return ((value * factor) % (step * factor)) / factor;
};

// if highlightNonLabel is true, we need to separate the unlabeled lines in order to render them in a different color
const { unlabeledLines, labeledLines } = (rowTickValues || []).reduce(
(acc, value) => {
if (highlightNonLabel && value % labelStep !== 0) {
if (highlightNonLabel && safeModulo(value, labelStep) !== 0) {
acc.unlabeledLines.push(value);
} else {
acc.labeledLines.push(value);
Expand All @@ -55,7 +67,7 @@ export class Grid extends React.Component {
width={size.width}
tickValues={labeledLines}
lineStyle={{
stroke: color.visualElementsColors.GRIDLINES_COLOR,
stroke: unlabeledLines.length ? color.visualElementsColors.GRIDLINES_COLOR : color.fadedPrimary(),
strokeWidth: 1,
}}
/>
Expand Down
Loading