fix(analytics): add error logging, init resilience, JSDoc, and compat test

- Add debug-level logging in analytics middleware catch block for
  observability without breaking request flow.
- Wrap AnalyticsService.init() in try/catch so PostHog failures
  degrade gracefully instead of crashing app startup.
- Add @param and @returns JSDoc to billing.init.js default export.
- Add explicit backward-compat test for undefined GDPR flags
  (captureIp/captureUserAgent) defaulting to capture.

Author: PierreBrisorgueil

lib/middlewares/analytics.js

@@ -2,6 +2,7 @@
  * Module dependencies
  */
 import AnalyticsService from '../services/analytics.js';
+import logger from '../services/logger.js';
 
 /**
  * Default route prefixes to skip when auto-capturing API request events.
@@ -51,7 +52,9 @@ const createAnalyticsMiddleware = (options = {}) => {
           statusCode: res.statusCode,
           responseTime: Date.now() - start,
         }, groups);
-      } catch (_) { /* analytics must not break request flow */ }
+      } catch (err) {
+        logger.debug('[analytics] finish handler error: %s', err.message);
+      }
     });
 
     return next();

lib/services/express.js

@@ -222,8 +222,13 @@ const init = async () => {
   await initPreParserRoutes(app);
   // Initialize analytics (PostHog) and mount auto-capture middleware
   // Mounted after pre-parser routes so webhooks are not tracked
-  await AnalyticsService.init();
-  app.use(analyticsMiddleware);
+  // Wrapped in try/catch so analytics failures never prevent app startup
+  try {
+    await AnalyticsService.init();
+    app.use(analyticsMiddleware);
+  } catch (err) {
+    logger.warn('[analytics] init failed, running without analytics: %s', err.message);
+  }
   // Initialize Express middleware
   initMiddleware(app);
   // Initialize Helmet security headers

modules/audit/tests/audit.service.unit.tests.js

@@ -147,4 +147,13 @@ describe('AuditService unit tests:', () => {
     const arg = mockCreate.mock.calls[0][0];
     expect(arg.userAgent).toBe('');
   });
+
+  test('should capture IP and User-Agent when flags are undefined (backward compat)', async () => {
+    mockConfig.audit = { enabled: true, ttlDays: 90 }; // no captureIp/captureUserAgent
+    const req = { ip: '10.0.0.1', headers: { 'user-agent': 'Bot/1.0' } };
+    await AuditService.log({ action: 'test.compat', req });
+    const arg = mockCreate.mock.calls[0][0];
+    expect(arg.ip).toBe('10.0.0.1');
+    expect(arg.userAgent).toBe('Bot/1.0');
+  });
 });

modules/billing/billing.init.js

@@ -7,6 +7,9 @@ import billingEvents from './lib/events.js';
 /**
  * Billing module initialisation.
  * Wires cross-module integrations that depend on services from lib.
+ *
+ * @param {import('express').Application} app - Express application instance
+ * @returns {Promise<void>}
  */
 // eslint-disable-next-line no-unused-vars
 export default async (app) => {