test(integration): config-aware billing equivalences + plan id (closes #3609) (#3610)

* test(integration): config-aware billing equivalences + plan id assertions (#3609)

- auth.integration: assert billing.equivalences against config.billing.equivalences
  (was hardcoded to null — broke any downstream that defines equivalences for /pricing)
- billing.lifecycle.integration: derive plan ids from config.billing.plans for the
  starter→pro transition test (was hardcoded 'starter' — broke any downstream whose
  plan enum excludes starter, e.g. trawl with free/growth/pro)

Tests still cover the upstream defaults (no planDefinitions → fallback to legacy
'starter'/'pro'; no equivalences → null) but no longer assume those values.

Refs #3609.

* fix(billing): use optional chaining on config.billing?.plans to guard against undefined

* fix(billing): correct comment — upstream defaults expose plans via planDefinitions

Author: PierreBrisorgueil

modules/auth/tests/auth.integration.tests.js

@@ -1542,7 +1542,7 @@ describe('Auth integration tests:', () => {
       expect(result.body.data.billing).toBeDefined();
       expect(typeof result.body.data.billing.enabled).toBe('boolean');
       expect(typeof result.body.data.billing.meterMode).toBe('boolean');
-      expect(result.body.data.billing.equivalences).toBeNull();
+      expect(result.body.data.billing.equivalences).toEqual(config.billing?.equivalences ?? null);
     });
 
     test('should reflect billing.meterMode=true when enabled (authenticated)', async () => {

modules/billing/tests/billing.lifecycle.integration.tests.js

@@ -70,19 +70,30 @@ describe('Billing meter lifecycle integration tests:', () => {
   });
 
   test('plan.changed webhook updates active week quota snapshot mid-week', async () => {
+    // Pick two distinct plan ids from the project's enum so the test runs on any downstream.
+    // Upstream defaults expose ['free','starter','pro','enterprise'] via planDefinitions;
+    // fallback to ['starter','pro'] only when plans array is absent or has fewer than 2 entries.
+    const plans = Array.isArray(config.billing?.plans) && config.billing.plans.length >= 2
+      ? config.billing.plans
+      : ['starter', 'pro'];
+    const initialPlan = plans[0];
+    const upgradePlan = plans[plans.length - 1];
+    const initialVersion = `${initialPlan}-v1`;
+    const upgradeVersion = `${upgradePlan}-v2`;
+
     config.billing.planDefinitions = [
-      { planId: 'starter', version: 'starter-v1', meterQuota: 100, ratios: { scrap: 1 } },
-      { planId: 'pro', version: 'pro-v2', meterQuota: 1000, ratios: { scrap: 1 } },
+      { planId: initialPlan, version: initialVersion, meterQuota: 100, ratios: { scrap: 1 } },
+      { planId: upgradePlan, version: upgradeVersion, meterQuota: 1000, ratios: { scrap: 1 } },
     ];
 
     const organizationId = new mongoose.Types.ObjectId();
     const weekKey = isoWeekKey(new Date());
-    await Organization.create({ _id: organizationId, name: 'Lifecycle Org', slug: 'lifecycle-org', plan: 'starter' });
+    await Organization.create({ _id: organizationId, name: 'Lifecycle Org', slug: 'lifecycle-org', plan: initialPlan });
     await Subscription.create({
       organization: organizationId,
       stripeCustomerId: 'cus_lifecycle',
       stripeSubscriptionId: 'sub_lifecycle',
-      plan: 'starter',
+      plan: initialPlan,
       status: 'active',
     });
     await BillingUsage.create({
@@ -92,7 +103,7 @@ describe('Billing meter lifecycle integration tests:', () => {
       counters: {},
       meterUsed: 25,
       meterQuota: 100,
-      planVersion: 'starter-v1',
+      planVersion: initialVersion,
       meterBreakdown: { scrap: 25 },
       consumedAttributionKeys: [],
     });
@@ -104,20 +115,20 @@ describe('Billing meter lifecycle integration tests:', () => {
         current_period_end: Math.floor(Date.now() / 1000) + 30 * 24 * 60 * 60,
         current_period_start: Math.floor(Date.now() / 1000) - 24 * 60 * 60,
         cancel_at_period_end: false,
-        items: { data: [{ price: { metadata: { planId: 'pro' } } }] },
+        items: { data: [{ price: { metadata: { planId: upgradePlan } } }] },
       },
       {
         data: {
           previous_attributes: {
-            items: { data: [{ price: { metadata: { planId: 'starter' } } }] },
+            items: { data: [{ price: { metadata: { planId: initialPlan } } }] },
           },
         },
       },
     );
 
     const usage = await BillingUsage.findOne({ organizationId, weekKey }).lean();
     expect(usage.meterQuota).toBe(1000);
-    expect(usage.planVersion).toBe('pro-v2');
+    expect(usage.planVersion).toBe(upgradeVersion);
     expect(usage.meterUsed).toBe(25);
     expect(usage.meterBreakdown).toEqual({ scrap: 25 });
   });