Skip to content

Commit 0e0bade

Browse files
test(home): fix regularUser fixture leak in readiness integration tests
Pre-clean regular-readiness@test.com before creating it to prevent unique index failures on re-runs, hoist to suite scope, and delete in afterAll.
1 parent 6eec090 commit 0e0bade

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

modules/home/tests/home.integration.tests.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ describe('Home integration tests:', () => {
2020
let adminToken;
2121
let adminUser;
2222
let userToken;
23+
let regularUser;
2324
let originalOrganizationsEnabled;
2425

2526
// init
@@ -55,7 +56,8 @@ describe('Home integration tests:', () => {
5556
adminToken = jwt.sign({ userId: adminUser.id }, config.jwt.secret, { expiresIn: config.jwt.expiresIn });
5657

5758
// Create regular user and sign JWT for readiness auth tests
58-
const regularUser = await User.create({
59+
await User.deleteOne({ email: 'regular-readiness@test.com' });
60+
regularUser = await User.create({
5961
firstName: 'Regular',
6062
lastName: 'User',
6163
email: 'regular-readiness@test.com',
@@ -371,9 +373,10 @@ describe('Home integration tests:', () => {
371373
jest.restoreAllMocks();
372374
config.organizations.enabled = originalOrganizationsEnabled;
373375
try {
374-
if (adminUser) {
376+
if (adminUser || regularUser) {
375377
const User = mongoose.model('User');
376-
await User.deleteOne({ _id: adminUser._id });
378+
if (adminUser) await User.deleteOne({ _id: adminUser._id });
379+
if (regularUser) await User.deleteOne({ _id: regularUser._id });
377380
}
378381
} catch (_) { /* cleanup – ignore errors */ }
379382
try {

0 commit comments

Comments
 (0)