fix(billing): admin sync reads period from items.data[0] (Stripe API ≥ 2025-08-27)

syncOrgFromStripe was reading current_period_start from the top-level
Stripe subscription object, which no longer exists on API version ≥ 2025-08-27.
The field moved to items.data[0].current_period_start. After an admin force-sync,
currentPeriodStart was written as null, silently dropping that subscription from
the weekly-reset sweep (findAllDueForResetByLastReset filters null out).

Mirror the dual-read fallback already used by the webhook handler:
items.data[0].current_period_start ?? current_period_start (top-level).

Fixes #3727.

Author: PierreBrisorgueil

modules/billing/services/billing.admin.service.js

@@ -94,8 +94,11 @@ const syncOrgFromStripe = async (orgId) => {
   const stripeSub = await stripe.subscriptions.retrieve(existing.stripeSubscriptionId);
   const newPlan = resolveStripePlan(stripeSub);
   const newStatus = stripeSub.status;
-  const newPeriodStart = stripeSub.current_period_start
-    ? new Date(stripeSub.current_period_start * 1000)
+  // Stripe API ≥ 2025-08-27 moved current_period_start to items.data[0].
+  // Read from items first, fall back to top-level for older API versions (mirrors webhook handler).
+  const rawPeriodStart = stripeSub.items?.data?.[0]?.current_period_start ?? stripeSub.current_period_start;
+  const newPeriodStart = rawPeriodStart
+    ? new Date(rawPeriodStart * 1000)
     : null;
 
   const previous = { plan: existing.plan, status: existing.status };

modules/billing/tests/billing.admin.service.unit.tests.js

@@ -239,6 +239,45 @@ describe('BillingAdminService unit tests:', () => {
     test('throws 422 for invalid orgId format', async () => {
       await expect(BillingAdminService.syncOrgFromStripe('bad-id')).rejects.toMatchObject({ status: 422 });
     });
+
+    test('writes non-null currentPeriodStart when period is only in items.data[0] (Stripe API ≥ 2025-08-27)', async () => {
+      // Simulate Stripe API ≥ 2025-08-27: top-level current_period_start is absent,
+      // period lives in items.data[0].current_period_start only.
+      const periodStart = 1750000000;
+      mockStripeInstance.subscriptions.retrieve.mockResolvedValue({
+        id: stripeSubId,
+        status: 'active',
+        current_period_start: undefined, // absent on new API
+        items: {
+          data: [{
+            current_period_start: periodStart,
+            price: { metadata: { planId: 'pro' } },
+          }],
+        },
+      });
+
+      await BillingAdminService.syncOrgFromStripe(orgId);
+
+      const updateCall = mockSubscriptionRepository.update.mock.calls[0][0];
+      expect(updateCall.currentPeriodStart).toEqual(new Date(periodStart * 1000));
+    });
+
+    test('falls back to top-level current_period_start when items.data[0] has none (legacy API)', async () => {
+      const periodStart = 1699000000;
+      mockStripeInstance.subscriptions.retrieve.mockResolvedValue({
+        id: stripeSubId,
+        status: 'active',
+        current_period_start: periodStart,
+        items: {
+          data: [{ price: { metadata: { planId: 'pro' } } }], // no current_period_start on item
+        },
+      });
+
+      await BillingAdminService.syncOrgFromStripe(orgId);
+
+      const updateCall = mockSubscriptionRepository.update.mock.calls[0][0];
+      expect(updateCall.currentPeriodStart).toEqual(new Date(periodStart * 1000));
+    });
   });
 
   // ─────────────────────────────────────────────────────────────────────────────